ci(): switch the old custom build for rollup #8013

asturur · 2022-06-19T08:05:58Z

This test works, but while the code changes seems large and aren't ( all whitespace and mandatory function wrapping ),
this change itself doesn't give us much.

I made this to have a small step transition that could allow tracing back issues to particular commits, and i would like the classes to transition one at one to be able to use git commit meaningfully.

If from this point modules can be migrated one by one ( starting from leaf nodes going up to the basic one ) ok then we can merge it, otherwise is pointless.

I ll experiment more and check

To look at PR:
https://github.com/fabricjs/fabric.js/pull/8013/files?diff=unified&w=1

most of the files will have changes like this.

github-actions · 2022-06-19T08:16:36Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.31 |     75.7 |   85.49 |   83.01 |                                               
 fabric.js |   83.31 |     75.7 |   85.49 |   83.01 | ...,30725,30799,30810-30875,30994,31093,31329 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-19T08:18:28Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.3 |    75.67 |   85.49 |      83 |                                               
 fabric.js |    83.3 |    75.67 |   85.49 |      83 | ...,30726,30800,30811-30876,30995,31094,31330 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur · 2022-06-19T08:19:24Z

ok browser import is broken

github-actions · 2022-06-19T09:31:16Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.29 |    75.66 |   85.49 |   82.99 |                                               
 fabric.js |   83.29 |    75.66 |   85.49 |   82.99 | ...,30800,30811-30876,30995,31094,31330,31489 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123 · 2022-06-19T18:04:36Z

@asturur why don't you want to use #7839 ?
It can be used to satisfy a one by one approach
and why not use es6 exports?

asturur · 2022-06-19T19:50:39Z

i m trying to add rollup without changing much else.
We can then use the transformer to change from the actual code to new code.

github-actions · 2022-06-19T20:23:57Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.3 |    75.72 |   85.48 |      83 |                                               
 fabric.js |    83.3 |    75.72 |   85.48 |      83 | ...,30791,30802-30867,30986,31085,31321,31480 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-19T20:50:13Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.32 |    75.77 |   85.54 |   83.02 |                                               
 fabric.js |   83.32 |    75.77 |   85.54 |   83.02 | ...,30790,30801-30866,30985,31084,31320,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur · 2022-06-19T20:55:23Z

i ll make a branch from here to test partial swapping of a single file or function to a different export method. But seems to work.

github-actions · 2022-06-19T20:58:52Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.31 |    75.74 |   85.54 |   83.01 |                                               
 fabric.js |   83.31 |    75.74 |   85.54 |   83.01 | ...,30790,30801-30866,30985,31084,31320,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123 · 2022-06-20T11:06:09Z

I have tested the new build.
My apps work with it without a problem.
Good job!

asturur · 2022-06-20T15:10:25Z

in a different branch i will convert a single function of the misc utils to TS, and see if that + ts + rollup-ts-whatever works
if it works it means this combination is sustainable

ShaMan123 · 2022-06-20T19:53:17Z

I checked the old build size with and without svg and found

file	svg	no svg	diff
fabric.js	1039 KB	993 KB	46 KB
fabric.min.js	312 KB	296 KB	16 KB

Is it a big enough difference to support svg as an opt in or can it be built in?

asturur · 2022-06-20T20:11:10Z

In theory we can move all the svg related functions in a different file and developers will import them when needed.
Hopefully the big fabric.* objects goes in disuse quickly.

of course 16kb is not that big, but if you are not doing anything with svg import and export, maybe you don't want to load that code anyway.

When everything is on import/export it should be very easy to do tests.

github-actions · 2022-06-25T07:41:42Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.36 |    75.75 |   85.54 |   82.09 |                                               
 fabric.js |   83.36 |    75.75 |   85.54 |   82.09 | ...,26629,26639-26683,26790,26877,27081,27218 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-25T18:47:36Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.32 |    75.72 |   85.55 |   82.04 |                                               
 fabric.js |   83.32 |    75.72 |   85.55 |   82.04 | ...,26637,26647-26691,26798,26885,27089,27226 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-25T20:19:10Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    75.75 |   85.55 |   82.05 |                                               
 fabric.js |   83.33 |    75.75 |   85.55 |   82.05 | ...,26637,26647-26691,26798,26885,27089,27226 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-25T20:31:03Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    75.75 |   85.55 |   82.05 |                                               
 fabric.js |   83.33 |    75.75 |   85.55 |   82.05 | ...,26637,26647-26691,26798,26885,27089,27226 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-25T20:58:11Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    75.75 |   85.55 |   82.05 |                                               
 fabric.js |   83.33 |    75.75 |   85.55 |   82.05 | ...,26637,26647-26691,26798,26885,27089,27226 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-25T21:00:36Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    75.75 |   85.55 |   82.05 |                                               
 fabric.js |   83.33 |    75.75 |   85.55 |   82.05 | ...,26637,26647-26691,26798,26885,27089,27226 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur · 2022-06-25T21:02:00Z

ok now the PR is green, i won't touch it.
Let's see if there is some large PR that we don't want to conflict because is too complex to fix, and then we can merge this.

ShaMan123 · 2022-06-26T03:35:38Z

I gave a look at my open PRs and I marked 3 huge ones:

feat(IText): Draggable text #7802
feat(): support aborting promises/requests #7827
~~feat(): includeDefaultValues arg #7719~~ low priority
feat(Object): fill-parent layout #7901 is also big but it depends on feat(Layer): 3rd Patch of Group Rewrite ♦️ #7860

asturur · 2022-06-26T13:03:20Z

I re read the draggable text pr, and while i m sure is a good feature we want to add, i currently don't like how we attach it to the events, i would like to write down all the pr is doing and see if we can break the code differently. Let me look the promises pr and let's get that in, then let's scehdule some time for the draggable text after i m sure i can expose my point of view and comunicate it properly.

github-actions · 2022-07-30T05:50:04Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |    74.52 |   84.49 |   80.73 |                                               
 fabric.js |   82.15 |    74.52 |   84.49 |   80.73 | ...,27373,27383-27427,27534,27621,27825,27965 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-07-30T06:03:14Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.16 |    74.55 |   84.49 |   80.74 |                                               
 fabric.js |   82.16 |    74.55 |   84.49 |   80.74 | ...,27373,27383-27427,27534,27621,27825,27965 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

Looks good

ShaMan123 · 2022-07-30T06:11:07Z

test/unit/canvas.js

@@ -105,7 +105,6 @@
   */
  QUnit.assert.sameImageObject = function (actual, expected) {
    var a = {}, b = {};
-    expected = expected || REFERENCE_IMG_OBJECT;


ShaMan123 · 2022-07-30T06:12:35Z

test/unit/group.js

@@ -889,7 +889,7 @@

    group1.addRelativeToGroup(rect5);
    var t = group1.calcTransformMatrix();
-    var pos = fabric.util.transformPoint(new fabric.Point(rect5.left, rect5.top), t);


I guess I wanted to check something here and didn't complete

ShaMan123 · 2022-07-30T06:13:07Z

src/util/dom_style.js

@@ -35,7 +36,7 @@
  var parseEl = fabric.document.createElement('div'),
      supportsOpacity = typeof parseEl.style.opacity === 'string',
      supportsFilters = typeof parseEl.style.filter === 'string',
-      reOpacity = /alpha\s*\(\s*opacity\s*=\s*([^\)]+)\)/,


are you sure about this?

ShaMan123 · 2022-07-30T06:15:19Z

src/typedefs.ts

@@ -0,0 +1,11 @@
+interface NominalTag<T> {
+  'nominalTag': T;


Suggested change

'nominalTag': T;

'nominalTag'?: T;

#8019 (comment)

d69e3dd of #8013

asturur added 9 commits June 18, 2022 16:53

removed function wrappers

5dd62f2

removed extra console warn

8357502

fixed whitespace with lint

70f9f5d

a test

fe9f785

a test

6563e3b

this sucls

5d62060

okish

278a813

the build

1142df0

lint

5fc125e

add window?

476d659

working browser

b7e3028

asturur changed the title ~~This is a test for rollup~~ ci(): switch the old custom build for rollup Jun 19, 2022

Merge branch 'master' into rollup-no-ws

cae461f

that was a test

fa8b7c0

Adding TS to rollup (#8019)

ea324d6

asturur added 2 commits June 25, 2022 20:41

ci(): Add linting (#8024)

2af0c08

Merge branch 'master' into rollup-no-ws

dd8f657

rename file as a test

434e74c

asturur added 2 commits June 25, 2022 22:23

use full installation

000457f

ok 3 installs

280c16b

asturur added 2 commits June 25, 2022 22:55

no resize test firefox

b5b93d1

ops

dad9996

stale bot added the stale Issue marked as stale by the stale bot label Jul 10, 2022

ShaMan123 added CI/CD and removed stale Issue marked as stale by the stale bot labels Jul 11, 2022

fabricjs deleted a comment from stale bot Jul 11, 2022

fixed conflicts

d69e3dd

maybe lint is ok now

f49dde0

asturur merged commit 07690b6 into master Jul 30, 2022

ShaMan123 reviewed Jul 30, 2022

View reviewed changes

ShaMan123 mentioned this pull request Aug 1, 2022

IMPORTANT: Migrating to modern javascript/typescript #7596

Closed

asturur deleted the rollup-no-ws branch September 11, 2022 23:03

ShaMan123 added a commit that referenced this pull request Dec 22, 2022

fix(): bad conflict resolution

db8739a

d69e3dd of #8013

ShaMan123 mentioned this pull request Dec 22, 2022

fix(): Draggable Text Migration Regression #8534

Merged

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

ci(): switch the old custom build for rollup (fabricjs#8013)

582d97b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(): switch the old custom build for rollup #8013

ci(): switch the old custom build for rollup #8013

asturur commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

asturur commented Jun 19, 2022

github-actions bot commented Jun 19, 2022 •

edited

Loading

ShaMan123 commented Jun 19, 2022 •

edited

Loading

asturur commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

asturur commented Jun 19, 2022

github-actions bot commented Jun 19, 2022 •

edited

Loading

ShaMan123 commented Jun 20, 2022 •

edited

Loading

asturur commented Jun 20, 2022

ShaMan123 commented Jun 20, 2022 •

edited

Loading

asturur commented Jun 20, 2022

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

asturur commented Jun 25, 2022

ShaMan123 commented Jun 26, 2022 •

edited

Loading

asturur commented Jun 26, 2022

github-actions bot commented Jul 30, 2022 •

edited

Loading

github-actions bot commented Jul 30, 2022 •

edited

Loading

ShaMan123 left a comment

ShaMan123 Jul 30, 2022

ShaMan123 Jul 30, 2022

ShaMan123 Jul 30, 2022

ShaMan123 Jul 30, 2022

ci(): switch the old custom build for rollup #8013

ci(): switch the old custom build for rollup #8013

Conversation

asturur commented Jun 19, 2022 • edited Loading

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

asturur commented Jun 19, 2022

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

ShaMan123 commented Jun 19, 2022 • edited Loading

asturur commented Jun 19, 2022 • edited Loading

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

asturur commented Jun 19, 2022

github-actions bot commented Jun 19, 2022 • edited Loading

Code Coverage Summary

ShaMan123 commented Jun 20, 2022 • edited Loading

asturur commented Jun 20, 2022

ShaMan123 commented Jun 20, 2022 • edited Loading

asturur commented Jun 20, 2022

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 25, 2022 • edited Loading

Code Coverage Summary

asturur commented Jun 25, 2022

ShaMan123 commented Jun 26, 2022 • edited Loading

asturur commented Jun 26, 2022

github-actions bot commented Jul 30, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jul 30, 2022 • edited Loading

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 Jul 30, 2022

Choose a reason for hiding this comment

ShaMan123 Jul 30, 2022

Choose a reason for hiding this comment

ShaMan123 Jul 30, 2022

Choose a reason for hiding this comment

ShaMan123 Jul 30, 2022

Choose a reason for hiding this comment

asturur commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

ShaMan123 commented Jun 19, 2022 •

edited

Loading

asturur commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 19, 2022 •

edited

Loading

ShaMan123 commented Jun 20, 2022 •

edited

Loading

ShaMan123 commented Jun 20, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading

ShaMan123 commented Jun 26, 2022 •

edited

Loading

github-actions bot commented Jul 30, 2022 •

edited

Loading

github-actions bot commented Jul 30, 2022 •

edited

Loading