Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #8191

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update CONTRIBUTING.md #8191

merged 1 commit into from
Aug 26, 2022

Conversation

jeroenrosendaal
Copy link
Contributor

Updated "Devleoping" to "Developing"

Updated "Devleoping" to "Developing"
@ShaMan123
Copy link
Contributor

thanks

@ShaMan123
Copy link
Contributor

@jeroenrosendaal the guide has been rewritten. After reading it, do you any comments? something needs more refining?

@ShaMan123 ShaMan123 merged commit 0594720 into fabricjs:master Aug 26, 2022
@jeroenrosendaal
Copy link
Contributor Author

@ShaMan123 I think the Developing section is a bit confusing if you never used codesandbox before. I tried using it but dit not succeed. I also tried building the project manually but came across some errors regarding the conversion to typescript files. Seems like the references inside the build.js file are not updated yet.

@jeroenrosendaal jeroenrosendaal deleted the patch-1 branch August 26, 2022 13:51
@ShaMan123
Copy link
Contributor

  1. build.js is deprecated - we switched to a new build system
  2. codesandbox is not directly related the the developing sectin. Please elaborate

@jeroenrosendaal
Copy link
Contributor Author

jeroenrosendaal commented Aug 26, 2022

@ShaMan123 What kind of build system do you use currently? I would like to test and contribute to the code. I've had some experience with the build.js. I assumed that codesandbox was the 'new way'.

@ShaMan123
Copy link
Contributor

we moved to rollup
the guide covers how to use the commands
npm run build etc.

@jeroenrosendaal
Copy link
Contributor Author

What guide are you referencing to?
I followed https://github.com/fabricjs/fabric.js#building section.
But npm run build did indeed the trick.

@ShaMan123
Copy link
Contributor

Ahh I see
That is on it's way out #8189

@ShaMan123
Copy link
Contributor

look here README

@jeroenrosendaal
Copy link
Contributor Author

Thanks!

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
Updated "Devleoping" to "Developing"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants