feat(): DrawShape, DrawOval, DrawPoly #8430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UT fail in deepEquals F it
7 tasks
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We discussed adding a poly brush to core.
I need it for a project so why not. Here it is.
closes #6319
Description
Interaction managers that are in charge of drawing a shape.
I have sticked to brush impl though I don't agree with the event naming and adding the shape to canvas by default. Thought that was best until we refactor all brushes (#8476 ).
Changes
_onDoubleClickcalls brush methodFurture PR should make all pointer events funnel through the active brush.
Gist
First merge #8417closes #8428
DrawShapeBase
base class to shape creation interaction
DrawShape
Simple and good pointer interaction creating a shape
DrawOval
same, extends
DrawShapeDrawPoly
What do you think about naming?
vpt isn't there yet, see videos below, I think this is a bug in canvas vpt when skewing, unrelated to the PR
In Action
fabric.js.sandbox.-.Google.Chrome.2022-11-07.21-18-40.mp4
centered + shiftKey
fabric.js.sandbox.-.Google.Chrome.2022-11-07.21-16-07.mp4
Unrelated and unexpected caching effect at the end
fabric.js.sandbox.-.Google.Chrome.2022-11-07.17-35-34.mp4
fabric.js.sandbox.-.Google.Chrome.2022-11-07.17-37-21.mp4
vpt
fabric.js.sandbox.-.Google.Chrome.2022-11-07.21-21-36.mp4
With vpt + objectCaching
BBox is off!
fabric.js.sandbox.-.Google.Chrome.2022-11-07.17-38-14.mp4