chore(TS): migrate Eraser #8499

ShaMan123 · 2022-12-08T10:21:40Z

Motivation

Description

Migrate eraser and refactor to a module.
Adapt fabric entities so there is no mutation done (the mixin used to mutate the prototypes of Object, Group, Canvas)
Can be regarded as Eraser v3, see v2 #7470 for reference

Changes

comply EraserBrush to brush pattern
perf(): doesn't need to do a full redraw of path each frame/step
perf(): optimize needsFullRender - move alpha checking to PencilBrush and descendants not including eraser (I think we should try masking PencilBrush, same as the eraser does, but with fillRect of color, that will make redrawing the entire path redundant in case of opacity, am I right?)
perf(PencilBrush): fixed straight line used to redraw until mouse up regardless of the straight line state
fix(): erasing + straight line
feat(): alpha erasing
fix(): clipPath, changed rendering logic so that first the brush draws over top context, then it is masked and then it is used to clip the main context. Makes fix(EraserBrush): visual trace while erasing #7991 erasing trace/artifact in free drawing mode #7984 obsolete and won't fix and enhances perf
feat(): updating, eraser will subscribe to canvas rendering and update its pattern
fix(): utilize renderCanvas to render pattern correctly (was missing out canvas#clipPath)

Gist

first merge feat(Brush API): Observable, clipPath #8476 clip-brush...ts-eraser
add tests
- no idea why top_ctx goldens are wrong... missing the opaic red rect that is visible when actually erasing
toSVG tests
opaic background destroys the eraser pattern... no idea why

In Action

fabric.js.sandbox.-.Google.Chrome.2022-12-11.16-55-56_Trim.mp4

With clip path

fabric.js.sandbox.-.Google.Chrome.2022-12-11.16-49-33_Trim.mp4

commit 82c8918 Merge: f6669ab eb25d2b Author: ShaMan123 <shacharnen@gmail.com> Date: Fri Jun 10 22:01:36 2022 +0300 Merge branch 'master' into pr/7175 commit f6669ab Author: ShaMan123 <shacharnen@gmail.com> Date: Thu May 12 10:06:51 2022 +0300 Update .eslintrc.json commit 0e4b9ef Author: ShaMan123 <shacharnen@gmail.com> Date: Thu May 12 10:01:03 2022 +0300 Revert "Update .eslintrc.json" This reverts commit b52caa0. commit b52caa0 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu May 12 09:53:19 2022 +0300 Update .eslintrc.json commit 082b063 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu May 12 09:30:35 2022 +0300 Revert whitespace This reverts whitespace commited by 3f0f328. commit 3f0f328 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu May 12 09:20:58 2022 +0300 fix(): `absolutePositioned` commit 3954fca Merge: 60b5829 06de045 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun May 1 20:06:30 2022 +0300 Merge branch 'master' into pr/7175 commit 60b5829 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 15:10:35 2022 +0300 Update base_brush.class.js commit 126514b Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 15:03:46 2022 +0300 async test commit 2d4aef7 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 14:57:23 2022 +0300 lint commit c36649f Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 14:50:36 2022 +0300 rename: BaseBrush `render` <-> `_render` now conforms with Object commit fddbae7 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 14:39:52 2022 +0300 async commit a8c1818 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 14:36:57 2022 +0300 async commit 8e20486 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 14:14:49 2022 +0300 update code to master commit d8eb923 Merge: f927143 4b3f9a3 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Apr 26 13:47:08 2022 +0300 Merge branch 'master' into pr/7175 commit f927143 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Feb 17 13:33:56 2022 +0200 Update base_brush.class.js commit 35c1364 Merge: 2442eed 70943e7 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Feb 17 13:27:07 2022 +0200 Merge remote-tracking branch 'upstream/master' into brush-clip-path commit 2442eed Author: ShaMan123 <shacharnen@gmail.com> Date: Mon Jan 17 14:27:29 2022 +0200 Update pencil_brush.class.js commit c2c856e Merge: 85a6317 56f0629 Author: ShaMan123 <shacharnen@gmail.com> Date: Mon Jan 17 14:22:26 2022 +0200 Merge remote-tracking branch 'upstream/master' into brush-clip-path commit 85a6317 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jan 16 15:47:58 2022 +0200 Update base_brush.class.js commit eef5936 Merge: 368dd71 a32be8a Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jan 16 15:43:46 2022 +0200 Merge remote-tracking branch 'upstream/master' into brush-clip-path commit 368dd71 Author: ShaMan123 <shacharnen@gmail.com> Date: Fri Jul 2 07:38:00 2021 +0300 Update eraser_brush.mixin.js commit 1ebccf4 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 22:55:38 2021 +0300 Update base_brush.class.js commit 5747e02 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 22:46:55 2021 +0300 fix rendering overlay with clip path commit a3eb5d7 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 22:02:56 2021 +0300 Update CHANGELOG.md commit 8fe3e37 Merge: 251a5df 3b99a2d Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 22:01:12 2021 +0300 Merge remote-tracking branch 'upstream/master' into brush-clip-path commit 251a5df Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 21:59:14 2021 +0300 revert dist commit ceaf13d Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 21:50:39 2021 +0300 lint commit 5680f1f Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 21:48:54 2021 +0300 support clipping eraser brush \ commit add527c Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 19:16:20 2021 +0300 Update eraser_brush.mixin.js commit 8b30537 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 19:13:11 2021 +0300 fix(absolutePositioned) commit 798199d Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 15:54:37 2021 +0300 support `inverted` property commit 9fea119 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 15:52:58 2021 +0300 handle `absolutePositioned` case commit 2640b2e Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 15:25:29 2021 +0300 BREAKING: rename `render` to `renderAll` To align with this PR commit 24489c4 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 15:00:50 2021 +0300 Update CHANGELOG.md commit 97ee528 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 14:54:05 2021 +0300 lint commit 99ff886 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 14:33:57 2021 +0300 JSDOC commit fc92fad Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 13:54:59 2021 +0300 Update pencil_brush.class.js commit 07fc81e Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 13:45:29 2021 +0300 addClipPathToResult expose `_addClipPathToResult` If there's a clip path set on the brush it is applied to the brush result commit 3cb75e4 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 13:31:50 2021 +0300 draw clipPath when adding a brush segment commit a824e91 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 08:25:41 2021 +0300 BREAKING CHANGE renamed `render` to `renderChuck` `render` method now renders all the spray to align with all the brushes commit cc5374d Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 08:24:37 2021 +0300 Update pencil_brush.class.js commit b551683 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 08:24:31 2021 +0300 Update circle_brush.class.js commit 373a450 Author: ShaMan123 <shacharnen@gmail.com> Date: Thu Jul 1 08:23:56 2021 +0300 Update base_brush.class.js

BREAKING CHANGE: stop adding brush result to canvas, dep path:created, before:path:created

fix(vpt): move to `absolutePointer` test

kyun · 2023-06-29T01:27:51Z

@ShaMan123 Is this PR still working?

ShaMan123 · 2023-06-29T02:11:38Z

We need to merge it
Not sure when

chrisp018 · 2023-10-06T15:52:05Z

Hi @ShaMan123, may we know this pr still on progress? do you know when it will be merged 🙇

ShaMan123 · 2023-10-07T07:32:00Z

I do not know
But it should
It is good to go, just needs to update from master

JeremyMees · 2023-11-13T14:20:34Z

@ShaMan123
Do you have idea now for when this is going to be added? I really don't wont to downgrade to version 5 😬
I hope this get's added soon because i really need it.

ShaMan123 · 2023-11-13T17:00:08Z

@asturur

ShaMan123 · 2023-11-13T17:01:14Z

I see this needs porting.
The diff is in a bad state

ShaMan123 · 2024-03-17T03:39:02Z

closing in favor of https://github.com/ShaMan123/erase2d

ShaMan123 added 30 commits November 21, 2022 16:12

Merge branch 'master' into poly-brush2

a936296

fix use setBoundingBox

4c28bbe

Create draw_shapes.js

31cae7f

extensive tests!

39bb29f

expose super class method transform

1e1db9a

BEAKING: brush _render, render

228b0a7

finalize, finalizeShape

b543910

shadow

6062754

move shadow setter to super

f73790a

Update path.class.ts

cb6dfe1

adapt eraser - not tested

01b47df

more

51daca3

Update base_brush.class.ts

3e6e425

Merge branch 'master' into poly-brush2

70c9e0f

Update CHANGELOG.md

4ab566d

imports

03e4150

fix merge artifact

6d182e0

Update DrawShapeBase.ts

c267640

imports/types

211bfe7

Merge branch 'master' into clip-brush

a90b2c7

fix merge

aaa9981

Merge branch 'poly-brush2' into clip-brush

92e8d4a

BREAKING: stop adding brush result to canvas

8222e6a

BREAKING CHANGE: stop adding brush result to canvas, dep path:created, before:path:created

more

15a49ce

fix clearing

5ace90d

Update freedraw.js

df0684c

better triggering

9a5b74d

fix(): clear context top on finalize

0f488bd

refactor tests

2cfa2d1

ShaMan123 added 17 commits February 5, 2023 00:39

setViewportTransform + drawing

bc0e900

Update brushes.js

5a1f381

Update PatternBrush.ts

60147f2

setVpt + brush.clipPath

9d3b47b

fix(vpt): move to absolutePointer

65da3a2

fix(vpt): move to `absolutePointer` test

fix setCoords timing

3c92b86

fix(): respect isDrawingMode

7d899bb

dep(): isDrawingMode => brush#enabled

01610a2

feat(FabricEvent): path

804ef49

feat(FabricEvent): stop propagation

7d9abf5

Merge branch 'master' into poly-brush2

2b86cde

Merge branch 'master' into clip-brush

dab541c

Update freedraw.js

d1a0fdf

Update FabricEvent.ts

f1f0843

Merge branch 'poly-brush2' into clip-brush

9358938

Merge branch 'clip-brush' into ts-eraser

0d6c164

Update EraserBrush.ts

b9493ed

tushuhei mentioned this pull request Apr 30, 2023

chore(TS): Enable strictPropertyInitialization #8876

Closed

ShaMan123 mentioned this pull request Jul 15, 2023

[Bug]: Erased path gets blurry after resize the object #9095

Closed

7 tasks

ShaMan123 mentioned this pull request Nov 2, 2023

BREAKING: remove absolute true/false from the api. #9395

Merged

ShaMan123 closed this Mar 17, 2024

ShaMan123 deleted the ts-eraser branch March 17, 2024 03:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(TS): migrate Eraser #8499

chore(TS): migrate Eraser #8499

ShaMan123 commented Dec 8, 2022 •

edited

Loading

kyun commented Jun 29, 2023

ShaMan123 commented Jun 29, 2023

chrisp018 commented Oct 6, 2023

ShaMan123 commented Oct 7, 2023

JeremyMees commented Nov 13, 2023 •

edited

Loading

ShaMan123 commented Nov 13, 2023

ShaMan123 commented Nov 13, 2023

ShaMan123 commented Mar 17, 2024

chore(TS): migrate Eraser #8499

chore(TS): migrate Eraser #8499

Conversation

ShaMan123 commented Dec 8, 2022 • edited Loading

Motivation

Description

Changes

Gist

In Action

kyun commented Jun 29, 2023

ShaMan123 commented Jun 29, 2023

chrisp018 commented Oct 6, 2023

ShaMan123 commented Oct 7, 2023

JeremyMees commented Nov 13, 2023 • edited Loading

ShaMan123 commented Nov 13, 2023

ShaMan123 commented Nov 13, 2023

ShaMan123 commented Mar 17, 2024

ShaMan123 commented Dec 8, 2022 •

edited

Loading

JeremyMees commented Nov 13, 2023 •

edited

Loading