Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: extend, clone => internal cloneDeep #8600

Merged
merged 28 commits into from
Jan 22, 2023
Merged

BREAKING: extend, clone => internal cloneDeep #8600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
27d33ee
Update .gitignore
ShaMan123 Jan 15, 2023
f4913f6
artifact mixins
ShaMan123 Jan 15, 2023
787efad
Update stateful.mixin.ts
ShaMan123 Jan 15, 2023
98ef94f
Update line.class.ts
ShaMan123 Jan 15, 2023
d6f7c38
Update Object.ts
ShaMan123 Jan 15, 2023
bd55fa9
cloneDeep
ShaMan123 Jan 15, 2023
1313a97
Update textStyles.ts
ShaMan123 Jan 15, 2023
0456ecb
Update index.ts
ShaMan123 Jan 15, 2023
6cbf2a8
tests
ShaMan123 Jan 15, 2023
dc08489
safeguard
ShaMan123 Jan 15, 2023
9b58dab
fix(): test
ShaMan123 Jan 15, 2023
138e008
Update textStyles.ts
ShaMan123 Jan 15, 2023
1c2b62f
safeguard
ShaMan123 Jan 15, 2023
11ec711
Update CHANGELOG.md
ShaMan123 Jan 15, 2023
369255d
Update textStyles.ts
ShaMan123 Jan 15, 2023
98497ef
types
ShaMan123 Jan 15, 2023
b20aac1
artifact imports
ShaMan123 Jan 15, 2023
adcc318
Merge branch 'master' into clone-deep
ShaMan123 Jan 16, 2023
f28e66c
this will cause a conflict with #8598
ShaMan123 Jan 16, 2023
9707637
Merge branch 'master' into clone-deep
ShaMan123 Jan 22, 2023
4eb0a37
Merge branch 'master' into clone-deep
ShaMan123 Jan 22, 2023
775b1c1
Update DraggableTextDelegate.ts
ShaMan123 Jan 22, 2023
4d3d2b5
Update itext_click_behaviour.js
ShaMan123 Jan 22, 2023
63f99c9
Merge branch 'master' into clone-deep
asturur Jan 22, 2023
dad3cbe
Update CHANGELOG.md
asturur Jan 22, 2023
6056fde
import reordering
asturur Jan 22, 2023
cf2c42d
more import reordering
asturur Jan 22, 2023
2c9dc2b
more reordering and somewhing wrong with my master
asturur Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- BREAKING: refactor `clone(obj, true)` with `cloneDeep(obj)` and remove all `extend`, `clone` calls in favor of object spreads. [#8600](https://github.com/fabricjs/fabric.js/pull/8600)
- chore(TS): Fix some error caused by ts-nocheck removals [#8615](https://github.com/fabricjs/fabric.js/pull/8615)
- refactor(IText): extract draggable text logic to a delegate [#8598](https://github.com/fabricjs/fabric.js/pull/8598)
- chore(TS): Update StaticCanvas to remove ts-nocheck [#8606](https://github.com/fabricjs/fabric.js/pull/8606)
Expand Down
5 changes: 0 additions & 5 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ import {
stylesToArray,
hasStyleChanged,
} from './src/util/misc/textStyles';
import { clone, extend } from './src/util/lang_object';
import {
createCanvasElement,
createImage,
Expand Down Expand Up @@ -196,10 +195,6 @@ const util = {
stylesToArray,
hasStyleChanged,
getElementOffset,
object: {
clone,
extend,
},
createCanvasElement,
createImage,
copyCanvasElement,
Expand Down
Loading