-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IText): drag image + retina #8712
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed width/height as you suggested.
moved the vpt logic to createCanvasElement
to keep text sharp by avoiding drawing images of text.
updated golden and made visual tests stricter
done
Motivation
drag image was blurry
Description
depends on #8711 to work properly but isn't blocked by it
Changes
createCanvasElement
to keep text sharp by avoiding drawing images of text.fixed
so adding to body will not affect layoutGist
In Action