lint(v6): fix eslint error #8726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UT fail in deepEquals F it
ShaMan123
suggested changes
Feb 22, 2023
There was a problem hiding this comment.
Thanks for this
Please double check changes and run the test suite
|
|
||
| const onComplete = callbacks.onComplete || empty | ||
| const onChange = callbacks.onChange || empty | ||
| const _this = this; |
There was a problem hiding this comment.
turn the functions into arrow functions and remove this line
https://github.com/fabricjs/fabric.js/pull/8726/files#diff-6db3fd5f9757a949bf2ea70c6ea366ecb5c1e3478306a26992b4e7f490c9c4c9R36-R45
| @@ -6,7 +6,7 @@ | |||
| * @return {Object} CSS rules of this document | |||
| */ | |||
| export function getCSSRules(doc) { | |||
| let styles = doc.getElementsByTagName('style'), | |||
| const styles = doc.getElementsByTagName('style'), | |||
There was a problem hiding this comment.
this is surely an error
you can move the definition of i to the loop and remove len if is used only once
| @@ -4,7 +4,7 @@ import { parseUnit } from '../util/misc/svgParsing'; | |||
| import { parseTransformAttribute } from './parseTransformAttribute'; | |||
|
|
|||
| export function normalizeValue(attr, value, parentAttributes, fontSize) { | |||
| let isArray = Array.isArray(value), | |||
| const isArray = Array.isArray(value), | |||
| @@ -45,7 +45,7 @@ export function normalizeValue(attr, value, parentAttributes, fontSize) { | |||
| } else if (attr === 'paintFirst') { | |||
| const fillIndex = value.indexOf('fill'); | |||
| const strokeIndex = value.indexOf('stroke'); | |||
| var value = 'fill'; | |||
| const value = 'fill'; | |||
| @@ -17,7 +17,7 @@ export function parsePointsAttribute(points) { | |||
| points = points.replace(/,/g, ' ').trim(); | |||
|
|
|||
| points = points.split(/\s+/); | |||
| let parsedPoints = [], | |||
| const parsedPoints = [], | |||
| @@ -13,7 +13,7 @@ import type { ValueAnimation } from '../../util/animation/ValueAnimation'; | |||
| import { TextStyleDeclaration } from '../Text/StyledText'; | |||
|
|
|||
| // extend this regex to support non english languages | |||
| const reNonWord = /[ \n\.,;!\?\-]/; | |||
| const reNonWord = /[ \n\\.,;!?-]/; | |||
There was a problem hiding this comment.
this is wrong I think.
\. === '.'
\\. === '' + any char?
Comment on lines
+1
to
+5
| src/mixins/eraser_brush.mixin.ts | ||
| src/util/lang_class.ts | ||
| src/filters/Resize.ts | ||
| src/parkinglot/canvas_animation.mixin.ts | ||
| src/parser/applyViewboxTransform.ts |
There was a problem hiding this comment.
Suggested change
| src/mixins/eraser_brush.mixin.ts | |
| src/util/lang_class.ts | |
| src/filters/Resize.ts | |
| src/parkinglot/canvas_animation.mixin.ts | |
| src/parser/applyViewboxTransform.ts | |
| src/mixins/eraser_brush.mixin.ts | |
| src/util/lang_class.ts | |
| src/parkinglot/canvas_animation.mixin.ts |
|
And I prefer you rebase to master so tests can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
fix eslint error,
#8476
Changes
Gist
In Action