-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(e2e): support relative imports #9108
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
READY
abs resolution + default imports
15e834a
to
ced8451
Compare
9dc431d
to
ec4ac28
Compare
Revert "Update setupApp.ts" This reverts commit 5dcd615.
5dcd615
to
fd4102f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test report (when failing) uploads only the index.html
which is useless - could not configure it to upload all the dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added matchers REVEVRTED it was causing issues
The issue i m about to have with those pr for e2e is that in this way it became super complex. |
Motivation
We want to use
index.ts
as a regular module so relative imports are a mustDescription
Using a babel plugin to transform relative imports to point to
e2e/dist
folder in neededChanges
Gist
In Action