Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(): try pull_request_target event to give access to fork prs #9455

Closed
wants to merge 4 commits into from
Closed

ci(): try pull_request_target event to give access to fork prs #9455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a944274
try pull_request_target event
asturur Oct 27, 2023
dfa6066
Update build.yml
asturur Oct 27, 2023
b56a531
update CHANGELOG.md
github-actions[bot] Oct 27, 2023
6de9e5f
move to node 20 to trigger something i think the changelog stopped my…
asturur Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
pull_request:
branches: [master]
paths-ignore: [CHANGELOG.md]
pull_request_target:
branches: [master]
paths-ignore: [CHANGELOG.md]

jobs:
build:
Expand All @@ -13,7 +16,7 @@ jobs:
uses: actions/checkout@v3
- uses: ./.github/actions/cached-install
with:
node-version: 18.x
node-version: 20.x
- run: npm run build
stats:
name: Build stats
Expand All @@ -27,7 +30,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- name: build stats
run: npm run build
Expand Down Expand Up @@ -75,7 +78,7 @@ jobs:
uses: actions/checkout@v3
- uses: ./.github/actions/cached-install
with:
node-version: 18.x
node-version: 20.x
- run: npm run lint
prettier:
runs-on: ubuntu-latest
Expand All @@ -84,5 +87,5 @@ jobs:
uses: actions/checkout@v3
- uses: ./.github/actions/cached-install
with:
node-version: 18.x
node-version: 20.x
- run: npm run prettier:check
2 changes: 2 additions & 0 deletions .github/workflows/changelog_required.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: '📋'
on:
pull_request:
branches: [master]
pull_request_target:
branches: [master]

jobs:
changelog:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/changelog_update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
pull_request:
branches: [master]
types: [opened, edited]
pull_request_target:
branches: [master]
types: [opened, edited]

jobs:
changelog:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- ci(): try pull_request_target event to give access to fork prs [#9455](https://github.com/fabricjs/fabric.js/pull/9455)
- BREAKING refactor(Canvas): remove `button` property from mouse events
- patch(Canvas): move event mouse:up:before earlier in the logic for more control [#9434](https://github.com/fabricjs/fabric.js/pull/9434)

Expand Down
Loading