-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): fix type of modifed event that could cause unexpected behaviour in dev code #9596
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Build Stats
|
target.fire('modified', options); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved so typescript can check
@asturur did you see this? WOW! You made it work? |
i got an email at some point 2-3 days ago asking me to enable something and i enabled it. |
I re triggered the request |
something does not work though, the links don't do anything after being opened |
Description
As #9500 but without refactors of code
close #9498