Add cmake_minimum_required to gtest.cmake.in #20
Conversation
Recent versions of CMake (e.g. 3.24.2) appear to fail unless the `cmake_minimum_required` version is set. Furthermore, we set `project` to silence the corresponding warning.
|
Great! Thanks for sending in the fix. |
|
Hi @nhusung! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@arnaudvenet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Recent versions of CMake (e.g. 3.24.2) appear to fail unless the `cmake_minimum_required` version is set. Furthermore, we set `project` to silence the corresponding warning. X-link: facebook/SPARTA#20 Reviewed By: yuxuanchen1997 Differential Revision: D41150912 Pulled By: arnaudvenet fbshipit-source-id: b1b37faa58ac5b24238ba196e1a8dbe202142272
Summary: Recent versions of CMake (e.g. 3.24.2) appear to fail unless the `cmake_minimum_required` version is set. Furthermore, we set `project` to silence the corresponding warning. X-link: facebook/SPARTA#20 Reviewed By: yuxuanchen1997 Differential Revision: D41150912 Pulled By: arnaudvenet fbshipit-source-id: b1b37faa58ac5b24238ba196e1a8dbe202142272
Recent versions of CMake (e.g. 3.24.2) appear to fail unless the
cmake_minimum_requiredversion is set. Furthermore, we setprojectto silence the corresponding warning.