Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint build error shouldn't include warnings in the output #4040

Closed
gaearon opened this issue Feb 18, 2018 · 3 comments
Closed

ESLint build error shouldn't include warnings in the output #4040

gaearon opened this issue Feb 18, 2018 · 3 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Feb 18, 2018

Noticed this with latest canary:

screen shot 2018-02-18 at 18 55 38

We should filter all warnings out when we fail the build.

@gaearon gaearon added this to the 2.0.0 milestone Feb 18, 2018
@n3tr
Copy link
Contributor

n3tr commented Feb 23, 2018

Look like this happen after we added thread-loader. it cause webpack report errors and warnings together as an error.

I tested by remove thread-loader and the output work fine.

@sadkovoy
Copy link

sadkovoy commented Jun 10, 2018

I tried to debug, and that's what I found out: with enabled thread-loader webpack returns object stats with following structure

{ "warnings": [], "errors": [/concatenated errors and warnings/] }
So every attempt to differ them like here

will be failed.
Probably it must be fixed in context of thread-loader repo.

@Timer
Copy link
Contributor

Timer commented Sep 17, 2018

This has been resolved in next.

@Timer Timer closed this as completed Sep 17, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants