Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn add -D firebase-tools breaks yarn test #4053

Closed
sharils opened this issue Feb 21, 2018 · 3 comments
Closed

yarn add -D firebase-tools breaks yarn test #4053

sharils opened this issue Feb 21, 2018 · 3 comments
Labels
contributions: up for grabs! difficulty: complex issue: needs investigation

Comments

@sharils
Copy link

sharils commented Feb 21, 2018

Environment:

  • node v9.5.0
  • npm 5.6.0
  • yarn 1.3.2
  • create-react-app 1.5.2

Steps to replicate:

Just one single command.

node -v && npm -v && yarn -v && create-react-app -V && cd /tmp/ && create-react-app test && cd test && yarn add -D firebase-tools && yarn test

Screencast:

yarn add -d firebase-tools breaks yarn test
@Timer
Copy link
Contributor

Timer commented Mar 5, 2018

You can try cross-posting this to Yarn/Jtes and see if someone is willing to dig into it, but it sounds like a dependency hoisting problem.
We don't have the time to dig into this so I'll tag it as up for grabs by a motivated contributor.

@Timer Timer mentioned this issue Mar 5, 2018
Closed
@ziras
Copy link

ziras commented Mar 6, 2018 •
edited
Loading

It seems that updating jest to 21.0.0 resolves this problem. Jest is pumped to 22 on next. Let's see if it solves that. Agree?

sharils added a commit to sharils/dinnerplano that referenced this issue Mar 22, 2018
@sharils
Work around facebook/create-react-app#4053
787ca07
sharils added a commit to sharils/dinnerplano that referenced this issue Apr 12, 2018
@sharils
Revert "Work around facebook/create-react-app#4053"
561faa2 
This reverts commit 787ca07.
@sharils sharils closed this as completed Apr 13, 2018
@sharils
Copy link
Author

sharils commented Apr 13, 2018

Fix in react-scripts@1.1.4

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: up for grabs! difficulty: complex issue: needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Timer @sharils @ziras