Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PWA manifest settings #4055

Closed
ri-ch opened this issue Feb 21, 2018 · 4 comments
Closed

Change PWA manifest settings #4055

ri-ch opened this issue Feb 21, 2018 · 4 comments

Comments

@ri-ch
Copy link

ri-ch commented Feb 21, 2018

Is this a bug report?

No

How do i change the values of the manifest.json file? At present my build command appears to copy the template manifest.json directly to the output.

@heyimalex
Copy link
Contributor

What are you expecting to happen? I think that yeah public/manifest.json is copied directly to build/manifest.json.

@ri-ch
Copy link
Author

ri-ch commented Feb 22, 2018

At the moment i just have a post build step that copies my own manifest.json file over the default one. I wondered if there was any way to generate it from the package.json or similar.

@heyimalex
Copy link
Contributor

Hm, can you just modify public/manifest.json? Apart from index.html, I think that everything from public is just copied over with no magic, and you're free to modify anything already there as you see fit.

@Timer
Copy link
Contributor

Timer commented Mar 5, 2018

Modify the file in public/manifest.json; if you need to modify it, a Node script in your postbuild npm-script would be the best option.

@Timer Timer closed this as completed Mar 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants