Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Jest moduleNameMapper regex back to a whitelist #1149

Merged
merged 1 commit into from
Dec 4, 2016
Merged

Revert Jest moduleNameMapper regex back to a whitelist #1149

merged 1 commit into from
Dec 4, 2016

Commits on Dec 4, 2016

  1. Revert Jest moduleNameMapper regex back to a whitelist 

    Jest matches moduleNameMapper regexes with module names, not the full
file path, so the negative lookahead doesn’t work for filtering out
JS files, because they can be imported without the extension. So paths
like `lodash.assign` and `../utils/range` were mislabeled as resources
with unknown file extensions because they have a dot in the name.

As a stopgap measure, revert the moduleNameMapper regex added in facebook#1077.
    @fson
    fson committed Dec 4, 2016
    Configuration menu
    Copy the full SHA
    3ab6d43 View commit details
    Browse the repository at this point in the history