New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon with sizes of 48, 32, 16 #3389

Closed

piotr-cz wants to merge 1 commit into facebook:master from piotr-cz:bugfix/favicon-sizes

Contributor

piotr-cz commented Nov 2, 2017 •

edited

Loading

Replaced favicon with new one with sizes 48x48, 32x32 and 16x16, which are recommended by MSDN (more info in this SO answer)

File size is bigger (15.086KB vs 3.860KB), as previous favicon has used a PNG format, current uses Windows BMP. Gzipped files have comparable size.

As input I've used this file: https://github.com/facebook/react-devtools/blob/master/shells/webextension/icons/production.svg, but changed color from #59c9f1 to #61dafb as it's used in logo.svg and on https://reactjs.org/ site.

Followup of #3374


          Favicon with sizes of 48, 32, 16

d640b30

facebook-github-bot added the CLA Signed label

Contributor Author

piotr-cz commented Nov 2, 2017

After learning more about the funky favicon format, I've decided to close this PR. Reasons:

Current file already uses the Optimal sizes, PR uses Recommended sizes
Current file uses PNGs inside ico file. I didn't find an easy way to generate similar output and using Windows BMP results in larger file size

piotr-cz closed this

piotr-cz deleted the bugfix/favicon-sizes branch

October 9, 2018 10:10

lock bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels