From 7784768bb91363681be7f4e32b35288e5bff3daa Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Mon, 30 Apr 2018 10:52:26 -0600 Subject: [PATCH 1/9] Add Node 10 to Travis config. Remove Node 6. --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 6dbea3e4ee5..1e35c7e66a2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ language: node_js node_js: - 8 - 9 + - 10 cache: directories: - node_modules From 08cacb9359dc81bf9551baa57b086f09fd22a1e3 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Mon, 7 May 2018 11:05:53 -0600 Subject: [PATCH 2/9] Add Node 10 to Appveyor config. Remove Node 6. --- appveyor.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 9cb7b58f8a4..f9fa49d0abc 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -2,21 +2,21 @@ image: Visual Studio 2017 environment: matrix: - - nodejs_version: 8 + - nodejs_version: 10 test_suite: "simple" - - nodejs_version: 8 + - nodejs_version: 10 test_suite: "installs" - - nodejs_version: 8 + - nodejs_version: 10 test_suite: "kitchensink" - nodejs_version: 8 test_suite: "kitchensink-eject" - nodejs_version: 8 test_suite: "monorepos" - - nodejs_version: 6 + - nodejs_version: 8 test_suite: "simple" - - nodejs_version: 6 + - nodejs_version: 8 test_suite: "installs" - - nodejs_version: 6 + - nodejs_version: 8 test_suite: "kitchensink" - nodejs_version: 6 test_suite: "kitchensink-eject" From 2433d85ede8a30010e0c35fbafe12b541d511e08 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Mon, 18 Jun 2018 11:42:22 -0600 Subject: [PATCH 3/9] Remove node 9 from travis config. --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1e35c7e66a2..35607c4584a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,7 +3,6 @@ dist: trusty language: node_js node_js: - 8 - - 9 - 10 cache: directories: From 4b7a90197d686541dd5f6de3810fc80013e91af0 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Mon, 18 Jun 2018 18:43:07 -0600 Subject: [PATCH 4/9] Increase mocha timeout. --- tasks/e2e-kitchensink.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index c79f9f77a10..c001a01e4da 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -151,7 +151,7 @@ E2E_URL="http://localhost:3001" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ CI=true \ @@ -159,7 +159,7 @@ E2E_FILE=./build/index.html \ NODE_ENV=production \ BABEL_ENV=test \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Cleanup cleanup From 6fb33743cba6ebaef107d55e54d2c60620b109a0 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Mon, 18 Jun 2018 20:30:12 -0600 Subject: [PATCH 5/9] Update minimum Node version to 8. --- packages/create-react-app/index.js | 2 +- tasks/local-test.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js index a093636609e..72ffe5f69d0 100755 --- a/packages/create-react-app/index.js +++ b/packages/create-react-app/index.js @@ -48,7 +48,7 @@ if (major < 4) { 'You are running Node ' + currentNodeVersion + '.\n' + - 'Create React App requires Node 4 or higher. \n' + + 'Create React App requires Node 8 or higher. \n' + 'Please update your version of Node.' ) ); diff --git a/tasks/local-test.sh b/tasks/local-test.sh index 877c6709717..222630f2170 100755 --- a/tasks/local-test.sh +++ b/tasks/local-test.sh @@ -8,7 +8,7 @@ function print_help { echo "Usage: ${0} [OPTIONS]" echo "" echo "OPTIONS:" - echo " --node-version the node version to use while testing [6]" + echo " --node-version the node version to use while testing [8]" echo " --git-branch the git branch to checkout for testing [the current one]" echo " --test-suite which test suite to use ('simple', installs', 'kitchensink', 'all') ['all']" echo " --interactive gain a bash shell after the test run" @@ -18,7 +18,7 @@ function print_help { cd $(dirname $0) -node_version=6 +node_version=8 current_git_branch=`git rev-parse --abbrev-ref HEAD` git_branch=${current_git_branch} test_suite=all From 6c3f3b1f73951710f4b843b5868b144446481038 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Sat, 14 Jul 2018 14:27:16 -0600 Subject: [PATCH 6/9] Update yarn to latest on Travis. --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 35607c4584a..5a3689d5757 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,6 +9,9 @@ cache: - node_modules - packages/create-react-app/node_modules - packages/react-scripts/node_modules +before_install: + - curl -o- -L https://yarnpkg.com/install.sh | bash + - export PATH="$HOME/.yarn/bin:$PATH" install: true script: - 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi' From dd63e726834c4ec741aa868badee07685d0058f0 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Sun, 15 Jul 2018 12:19:37 -0600 Subject: [PATCH 7/9] Update old-node test to use Node 4. --- .travis.yml | 2 +- packages/create-react-app/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5a3689d5757..7ddf00439cc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -29,7 +29,7 @@ env: - TEST_SUITE=monorepos matrix: include: - - node_js: 0.10 + - node_js: 4 env: TEST_SUITE=old-node - node_js: 6 env: TEST_SUITE=kitchensink diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js index 72ffe5f69d0..808ebcfe69c 100755 --- a/packages/create-react-app/index.js +++ b/packages/create-react-app/index.js @@ -42,7 +42,7 @@ var currentNodeVersion = process.versions.node; var semver = currentNodeVersion.split('.'); var major = semver[0]; -if (major < 4) { +if (major < 8) { console.error( chalk.red( 'You are running Node ' + From ac7031fc3456ea53eab24aabf816c9dc7df02e56 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Sun, 15 Jul 2018 12:27:29 -0600 Subject: [PATCH 8/9] Increase mocha timeout in kitchensink-eject tests. --- .travis.yml | 6 +----- appveyor.yml | 8 ++++---- tasks/e2e-kitchensink-eject.sh | 4 ++-- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7ddf00439cc..a014151cf6a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,8 +18,8 @@ script: - 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi' - 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi' - 'if [ $TEST_SUITE = "kitchensink-eject" ]; then tasks/e2e-kitchensink-eject.sh; fi' - - 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi' - 'if [ $TEST_SUITE = "monorepos" ]; then tasks/e2e-monorepos.sh; fi' + - 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi' env: matrix: - TEST_SUITE=simple @@ -31,7 +31,3 @@ matrix: include: - node_js: 4 env: TEST_SUITE=old-node - - node_js: 6 - env: TEST_SUITE=kitchensink - - node_js: 6 - env: TEST_SUITE=kitchensink-eject diff --git a/appveyor.yml b/appveyor.yml index f9fa49d0abc..306fa72b9fb 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,9 +8,9 @@ environment: test_suite: "installs" - nodejs_version: 10 test_suite: "kitchensink" - - nodejs_version: 8 + - nodejs_version: 10 test_suite: "kitchensink-eject" - - nodejs_version: 8 + - nodejs_version: 10 test_suite: "monorepos" - nodejs_version: 8 test_suite: "simple" @@ -18,9 +18,9 @@ environment: test_suite: "installs" - nodejs_version: 8 test_suite: "kitchensink" - - nodejs_version: 6 + - nodejs_version: 8 test_suite: "kitchensink-eject" - - nodejs_version: 6 + - nodejs_version: 8 test_suite: "monorepos" cache: - node_modules -> appveyor.cleanup-cache.txt diff --git a/tasks/e2e-kitchensink-eject.sh b/tasks/e2e-kitchensink-eject.sh index 76a50f1b8be..ef7a511dc23 100755 --- a/tasks/e2e-kitchensink-eject.sh +++ b/tasks/e2e-kitchensink-eject.sh @@ -159,7 +159,7 @@ E2E_URL="http://localhost:3002" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ @@ -168,7 +168,7 @@ E2E_FILE=./build/index.html \ BABEL_ENV=test \ NODE_PATH=src \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Cleanup cleanup From 9828d6cab14e8f94b3b07e371163f8b567423644 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Sun, 15 Jul 2018 17:53:26 -0600 Subject: [PATCH 9/9] Update yarn to latest on Appveyor. --- appveyor.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/appveyor.yml b/appveyor.yml index 306fa72b9fb..a4315250399 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -36,6 +36,9 @@ platform: install: - ps: Install-Product node $env:nodejs_version $env:platform + - ps: | + (New-Object Net.WebClient).DownloadFile("https://yarnpkg.com/latest.msi", "$env:temp\yarn.msi") + cmd /c start /wait msiexec.exe /i $env:temp\yarn.msi /quiet /qn /norestart build: off @@ -46,4 +49,5 @@ skip_commits: test_script: - node --version - npm --version + - yarn --version - bash tasks/e2e-%test_suite%.sh