From 9701ba820462284624c74e1051c2a418c8f72590 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Tue, 18 Sep 2018 18:00:18 -0400 Subject: [PATCH 1/3] Disable webpack chunk rollup --- packages/react-scripts/config/webpack.config.dev.js | 2 +- packages/react-scripts/config/webpack.config.prod.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js index 643fa1798d1..d46a9c6698a 100644 --- a/packages/react-scripts/config/webpack.config.dev.js +++ b/packages/react-scripts/config/webpack.config.dev.js @@ -121,7 +121,7 @@ module.exports = { // https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366 splitChunks: { chunks: 'all', - name: 'vendors', + name: false, }, // Keep the runtime chunk seperated to enable long term caching // https://twitter.com/wSokra/status/969679223278505985 diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js index 010a5db4c20..94d72d6d1ed 100644 --- a/packages/react-scripts/config/webpack.config.prod.js +++ b/packages/react-scripts/config/webpack.config.prod.js @@ -159,7 +159,7 @@ module.exports = { // https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366 splitChunks: { chunks: 'all', - name: 'vendors', + name: false, }, // Keep the runtime chunk seperated to enable long term caching // https://twitter.com/wSokra/status/969679223278505985 From 25174f8fca3b99cc6a3f635906226424cb96fc05 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Tue, 18 Sep 2018 20:24:02 -0400 Subject: [PATCH 2/3] Bump timeout --- tasks/e2e-kitchensink-eject.sh | 4 ++-- tasks/e2e-kitchensink.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tasks/e2e-kitchensink-eject.sh b/tasks/e2e-kitchensink-eject.sh index ef7a511dc23..bf632e2ee00 100755 --- a/tasks/e2e-kitchensink-eject.sh +++ b/tasks/e2e-kitchensink-eject.sh @@ -159,7 +159,7 @@ E2E_URL="http://localhost:3002" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ @@ -168,7 +168,7 @@ E2E_FILE=./build/index.html \ BABEL_ENV=test \ NODE_PATH=src \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Cleanup cleanup diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index c6011997cf8..f3669012525 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -155,7 +155,7 @@ E2E_URL="http://localhost:3001" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ CI=true \ @@ -163,7 +163,7 @@ E2E_FILE=./build/index.html \ NODE_ENV=production \ BABEL_ENV=test \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Remove the config we just created for Mocha # TODO: this is very hacky and we should find some other solution From 77f60edd1b3c93396583ef99b2ca3bd8a7fbac82 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Wed, 19 Sep 2018 08:38:26 -0400 Subject: [PATCH 3/3] Revert "Bump timeout" This reverts commit 84632115d178b48e08eb75dc5e9a921ece6aa759. --- tasks/e2e-kitchensink-eject.sh | 4 ++-- tasks/e2e-kitchensink.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tasks/e2e-kitchensink-eject.sh b/tasks/e2e-kitchensink-eject.sh index bf632e2ee00..ef7a511dc23 100755 --- a/tasks/e2e-kitchensink-eject.sh +++ b/tasks/e2e-kitchensink-eject.sh @@ -159,7 +159,7 @@ E2E_URL="http://localhost:3002" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ @@ -168,7 +168,7 @@ E2E_FILE=./build/index.html \ BABEL_ENV=test \ NODE_PATH=src \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Cleanup cleanup diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index f3669012525..c6011997cf8 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -155,7 +155,7 @@ E2E_URL="http://localhost:3001" \ CI=true NODE_PATH=src \ NODE_ENV=development \ BABEL_ENV=test \ - node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Test "production" environment E2E_FILE=./build/index.html \ CI=true \ @@ -163,7 +163,7 @@ E2E_FILE=./build/index.html \ NODE_ENV=production \ BABEL_ENV=test \ PUBLIC_URL=http://www.example.org/spa/ \ - node_modules/.bin/mocha --timeout 60000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js + node_modules/.bin/mocha --timeout 30000 --compilers js:@babel/register --require @babel/polyfill integration/*.test.js # Remove the config we just created for Mocha # TODO: this is very hacky and we should find some other solution