From a5c83ac296a43361e7937bcea78ffe76e3359a64 Mon Sep 17 00:00:00 2001 From: javadoug Date: Fri, 13 Sep 2019 18:56:46 -0400 Subject: [PATCH 1/2] change runtime chunk name tilde is now dash (#5358) --- packages/react-scripts/config/webpack.config.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index c1403a51920..8150c7a2b34 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -277,7 +277,10 @@ module.exports = function(webpackEnv) { }, // Keep the runtime chunk separated to enable long term caching // https://twitter.com/wSokra/status/969679223278505985 - runtimeChunk: true, + // https://github.com/facebook/create-react-app/issues/5358 + runtimeChunk: { + name: entrypoint => `runtime-${entrypoint.name}`, + }, }, resolve: { // This allows you to set a fallback for where Webpack should look for modules. From fb95a3eed7adb85b7f380ff352f792c2798ecd3d Mon Sep 17 00:00:00 2001 From: javadoug Date: Fri, 13 Sep 2019 19:23:14 -0400 Subject: [PATCH 2/2] update inline chunk html plugin config for new chunkname with dash (#5358) --- packages/react-scripts/config/webpack.config.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index 8150c7a2b34..f75782722d7 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -592,9 +592,10 @@ module.exports = function(webpackEnv) { ), // Inlines the webpack runtime script. This script is too small to warrant // a network request. + // https://github.com/facebook/create-react-app/issues/5358 isEnvProduction && shouldInlineRuntimeChunk && - new InlineChunkHtmlPlugin(HtmlWebpackPlugin, [/runtime~.+[.]js/]), + new InlineChunkHtmlPlugin(HtmlWebpackPlugin, [/runtime-.+[.]js/]), // Makes some environment variables available in index.html. // The public URL is available as %PUBLIC_URL% in index.html, e.g.: //