From 0d018a88c5bccb56474b4dd0bb9cc7aaab4ad3e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Lorber?= Date: Tue, 1 Sep 2020 19:40:37 +0200 Subject: [PATCH] fix(v2): script tags should allow unknown values (#3385) https://github.com/facebook/docusaurus/issues/3378 --- .../docusaurus/src/server/__tests__/configValidation.test.ts | 1 + packages/docusaurus/src/server/configValidation.ts | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/docusaurus/src/server/__tests__/configValidation.test.ts b/packages/docusaurus/src/server/__tests__/configValidation.test.ts index 23bf04fb7442..c6eb2e39d2e7 100644 --- a/packages/docusaurus/src/server/__tests__/configValidation.test.ts +++ b/packages/docusaurus/src/server/__tests__/configValidation.test.ts @@ -42,6 +42,7 @@ describe('normalizeConfig', () => { src: `/analytics.js`, async: true, defer: true, + 'data-domain': 'xyz', // See https://github.com/facebook/docusaurus/issues/3378 }, ], stylesheets: [ diff --git a/packages/docusaurus/src/server/configValidation.ts b/packages/docusaurus/src/server/configValidation.ts index cf5b5ad42a5a..f4fbe9bdb336 100644 --- a/packages/docusaurus/src/server/configValidation.ts +++ b/packages/docusaurus/src/server/configValidation.ts @@ -77,7 +77,9 @@ const ConfigSchema = Joi.object({ src: Joi.string().required(), async: Joi.bool(), defer: Joi.bool(), - }), + }) + // See https://github.com/facebook/docusaurus/issues/3378 + .unknown(), ), stylesheets: Joi.array().items( Joi.string(),