Have cocoapods rebuild FacebookSDKStrings.bundle so xcode processes strings files #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cltnschlosser
requested review from
jingping2015,
joesus,
kalendae and
robtimp
as code owners
shekita88
approved these changes
Apr 11, 2021
shekita88
approved these changes
Apr 11, 2021
…trings files The end result is the final product ends up converting the strings files from the current text format to a minified binary plist format. Size change: Before 246,293 bytes (365 KB on disk) After 133,039 bytes (184 KB on disk) Nice ~100KB win for installed app size. I decided to leave the bundle alone instead of breaking out the strings into their own folder because I didn't know if anything else was using the bundle currently. It doesn't look like spm is using it, which is probably a bug. Also I'm not sure if these strings have test coverage or not, but if not I can help make sure various translations are still working correctly. Not sure where exactly these strings are used.
cltnschlosser
force-pushed
the
cs_binaryPlistStrings
branch
from
6b1e171 to
a115663
Compare
cltnschlosser
force-pushed
the
cs_binaryPlistStrings
branch
from
a115663 to
6a30ea8
Compare
|
Can someone take a look at this. Thanks |
|
@joesus has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks for the contribution! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end result is the final product ends up converting the strings files from the current text format to a minified binary plist format.
Size change:
Before
246,293 bytes (365 KB on disk)
After
133,039 bytes (184 KB on disk)
Nice ~100KB win for installed app size.
I decided to leave the bundle alone instead of breaking out the strings into their own folder because I didn't know if anything else was using the bundle currently. It doesn't look like spm is using it, which is probably a bug.
Also I'm not sure if these strings have test coverage or not, but if not I can help make sure various translations are still working correctly. Not sure where exactly these strings are used.
To help us review the request, please complete the following:
bugfor bug fixes) I can't add labels.