Add Swift 3.0 support. #58
Conversation
ghost
added
GH Review: review-needed
CLA Signed
| public static func CompletedTutorial(successful successful: BooleanType? = nil, | ||
| valueToSum: Double? = nil, | ||
| extraParameters: ParametersDictionary = [:]) -> AppEvent { | ||
| public static func completedTutorial(successful: DarwinBoolean? = nil, |
There was a problem hiding this comment.
DarwinBoolean probably isn't the right choice here.
There was a problem hiding this comment.
Good catch, need to update.
| extraParameters: ParametersDictionary = [:]) -> AppEvent { | ||
| public static func searched(contentId: String? = nil, | ||
| searchedString: String? = nil, | ||
| successful: DarwinBoolean? = nil, |
There was a problem hiding this comment.
Good catch, need to update.
| public static func AddedPaymentInfo(successful successful: BooleanType? = nil, | ||
| valueToSum: Double? = nil, | ||
| extraParameters: ParametersDictionary = [:]) -> AppEvent { | ||
| public static func addedPaymentInfo(successful: DarwinBoolean? = nil, |
There was a problem hiding this comment.
Good catch, need to update.
| @@ -59,7 +59,7 @@ extension GraphRequestProtocol { | |||
|
|
|||
| - parameter completion: Optional completion closure that is going to be called when the connection finishes or fails. | |||
| */ | |||
| public func start(completion: ((httpResponse: NSHTTPURLResponse?, result: GraphRequestResult<Self>) -> Void)? = nil) { | |||
| public func start(_ completion: @escaping GraphRequestConnection.Completion<Self>) { | |||
There was a problem hiding this comment.
Shouldn't this be GraphRequestConnection<Self>.Completion? The typealias itself doesn't have the generic paramter, GraphRequestConnection does, no?
There was a problem hiding this comment.
Yes, will update.
|
|
||
| /// The aspect ratio of the source image of the profile picture. | ||
| public var pictureAspectRatio = UserProfile.PictureAspectRatio.Square { | ||
| open var pictureAspectRatio = UserProfile.PictureAspectRatio.square { |
There was a problem hiding this comment.
open here should do nothing, as PictureView is final, no?
There was a problem hiding this comment.
I knew I missed one of these.
| } | ||
|
|
||
| /** | ||
| Logs the user out. | ||
| This calls `AccessToken.current = nil` and `Profile.current = nil`. | ||
| */ | ||
| public func logOut() { | ||
| open func logOut() { |
There was a problem hiding this comment.
Again, open on a final class?
There was a problem hiding this comment.
Yup, should be public.
nlutsenko
force-pushed
the
nlutsenko.swift30
branch
from
4c10185
to
e6e2845
Compare
|
@richardjrossiii, updated and rebased:
|
nlutsenko
force-pushed
the
nlutsenko.swift30
branch
6 times, most recently
from
74305de
to
856a973
Compare
|
When I add the Facebook dependencies to my Podfile it loads an older version of the SDK. Is there something I'm missing? The readme says that's all you should have to do. I've tried copying all the newer swift files in, but that was fraught with errors...I was able to get it working by using the legacy swift option. Thanks! |
|
This seems to be merged into master, but I can't get it to compile with Swift 3.0 in Xcode 8.0. |
|
@ricardochavarria I'm seeing this issue as of today. Have you worked around it or still waiting? |
|
I did find a workaround of sorts. I load the standard SDK through my podfile and when I open the new workspace I run the "Convert to Swift 3 Syntax" wizard and it works after that. Just have to build the project afterwards and everything is fine. Thanks! |
|
@aliabadi when you said the standard... Do you mean the Obj-C or the swift sdk? |
Most of the changes are simply due to language syntax change, but there are few API changes as well to make the SDK more Swifty :)
Kudos and thanks to:
@escapingbehavior with generic types (it's implicitly@escaping)Closes #53