thrift build fix for rocketupgrade lib

Summary:
Found issue:

```
FAILED: fbzmq/zmq_monitor_client_test
: && /usr/bin/c++  -Wall -Wextra -Werror -Wno-noexcept-type -Wno-deprecated-declarations -O2 -g -DNDEBUG  -rdynamic fbzmq/CMakeFiles/zmq_monitor_client_test.dir/service/monitor/tests/ZmqMonitorClientTest.cpp.o  -o fbzmq/zmq_monitor_client_test  -Wl,-rpath,/data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/libzmq-WYNUZ5VYcelOAY3uV_bjnHhzwQrgoK4MvHyCMsp1MuM/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/zstd-nu72lnvEO9fXOOi7ZDqer47syM_R4CVWONQAAxQ0V5g/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-w4Hybv-wJ190T-fglHVpnK3xq1CxUGT9RtVGDA7QpaM/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/libsodium-e0bvqBDnJ4y9whbWaG6aIRWX0Xb17alEHHIoSi2Hz9c/lib fbzmq/libfbzmq.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest_main.a fbzmq/libmonitor_cpp2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib/libglog.so /data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib/libgflags.so.2.2.2 /data/sandcastle/temp/fbcode_builder_getdeps/installed/libzmq-WYNUZ5VYcelOAY3uV_bjnHhzwQrgoK4MvHyCMsp1MuM/lib/libzmq.so -lpthread /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftcpp2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftfrozen2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftmetadata.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libasync.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libtransport.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librpcmetadata.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libconcurrency.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthrift-core.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/wangle/lib/libwangle.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fizz/lib/libfizz.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/folly/lib/libfolly.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fmt-XC_RDlIh_QfDiWVKV15MrgHVykUKaWg5dp-5MlmMLoc/lib/libfmt.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_filesystem.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_program_options.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_regex.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_system.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_thread.a -pthread /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_chrono.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_date_time.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_atomic.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/libevent-SfVb6EMfp14dO1ACJpoFHGVUEsS5yLPksnxEKjSa2mw/lib/libevent.a -lz -lbz2 -llzma /data/sandcastle/temp/fbcode_builder_getdeps/installed/lz4-EcyPuwYsuHakUlA-kWxer8wHvXjm9kQFsGAS-N5bd98/lib/liblz4.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/zstd-nu72lnvEO9fXOOi7ZDqer47syM_R4CVWONQAAxQ0V5g/lib/libzstd.so /data/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-w4Hybv-wJ190T-fglHVpnK3xq1CxUGT9RtVGDA7QpaM/lib/libsnappy.so -ldwarf -Wl,-Bstatic -liberty -Wl,-Bdynamic -lsodium -lunwind /data/sandcastle/temp/fbcode_builder_getdeps/installed/double-conversion-y46-Q4-Wds7DK27aDIxuW79GtOdq8ODZK6B7jzYHlhc/lib/libdouble-conversion.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib/libgflags.so.2.2.2 /data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib/libglog.so -lssl -lcrypto -ldl /data/sandcastle/temp/fbcode_builder_getdeps/installed/libsodium-e0bvqBDnJ4y9whbWaG6aIRWX0Xb17alEHHIoSi2Hz9c/lib/libsodium.so -lrt /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_context.a -ldl /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest.a -lpthread && :
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::RocketUpgradeAsyncClient::upgradeToRocketImpl(apache::thrift::RpcOptions const&, std::shared_ptr<apache::thrift::detail::ac::ClientRequestContext>, std::unique_ptr<apache::thrift::RequestClientCallback, apache::thrift::RequestClientCallback::RequestClientCallbackDeleter>)':
/data/sandcastle/temp/fbcode_builder_getdeps/build/fbthrift/thrift/lib/thrift/gen-cpp2/RocketUpgradeAsyncClient.cpp:61: undefined reference to `apache::thrift::detail::ac::throw_app_exn(char const*)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::preprocessSendT<apache::thrift::BinaryProtocolWriter>(apache::thrift::BinaryProtocolWriter*, apache::thrift::RpcOptions const&, apache::thrift::ContextStack&, apache::thrift::transport::THeader&, folly::Range<char const*>, folly::FunctionRef<void (apache::thrift::BinaryProtocolWriter*)>, folly::FunctionRef<unsigned long (apache::thrift::BinaryProtocolWriter*)>)::{lambda()#1}::operator()() const':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/async/RequestChannel.h:332: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::preprocessSendT<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*, apache::thrift::RpcOptions const&, apache::thrift::ContextStack&, apache::thrift::transport::THeader&, folly::Range<char const*>, folly::FunctionRef<void (apache::thrift::CompactProtocolWriter*)>, folly::FunctionRef<unsigned long (apache::thrift::CompactProtocolWriter*)>)::{lambda()#1}::operator()() const':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/async/RequestChannel.h:332: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `folly::exception_wrapper apache::thrift::detail::ac::recv_wrapped_helper<apache::thrift::BinaryProtocolReader, apache::thrift::ThriftPresult<true> >(char const*, apache::thrift::BinaryProtocolReader*, apache::thrift::ClientReceiveState&, apache::thrift::ThriftPresult<true>&)':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.h:503: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `folly::exception_wrapper apache::thrift::detail::ac::recv_wrapped_helper<apache::thrift::CompactProtocolReader, apache::thrift::ThriftPresult<true> >(char const*, apache::thrift::CompactProtocolReader*, apache::thrift::ClientReceiveState&, apache::thrift::ThriftPresult<true>&)':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.h:503: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'

FAILED: fbzmq/zmq_monitor_test
: && /usr/bin/c++  -Wall -Wextra -Werror -Wno-noexcept-type -Wno-deprecated-declarations -O2 -g -DNDEBUG  -rdynamic fbzmq/CMakeFiles/zmq_monitor_test.dir/service/monitor/tests/ZmqMonitorTest.cpp.o  -o fbzmq/zmq_monitor_test  -Wl,-rpath,/data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/libzmq-WYNUZ5VYcelOAY3uV_bjnHhzwQrgoK4MvHyCMsp1MuM/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/zstd-nu72lnvEO9fXOOi7ZDqer47syM_R4CVWONQAAxQ0V5g/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-w4Hybv-wJ190T-fglHVpnK3xq1CxUGT9RtVGDA7QpaM/lib:/data/sandcastle/temp/fbcode_builder_getdeps/installed/libsodium-e0bvqBDnJ4y9whbWaG6aIRWX0Xb17alEHHIoSi2Hz9c/lib fbzmq/libfbzmq.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest_main.a fbzmq/libmonitor_cpp2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib/libglog.so /data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib/libgflags.so.2.2.2 /data/sandcastle/temp/fbcode_builder_getdeps/installed/libzmq-WYNUZ5VYcelOAY3uV_bjnHhzwQrgoK4MvHyCMsp1MuM/lib/libzmq.so -lpthread /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftcpp2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftfrozen2.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftmetadata.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libasync.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libtransport.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librpcmetadata.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libconcurrency.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/libthrift-core.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/wangle/lib/libwangle.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fizz/lib/libfizz.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/folly/lib/libfolly.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/fmt-XC_RDlIh_QfDiWVKV15MrgHVykUKaWg5dp-5MlmMLoc/lib/libfmt.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_filesystem.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_program_options.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_regex.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_system.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_thread.a -pthread /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_chrono.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_date_time.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_atomic.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/libevent-SfVb6EMfp14dO1ACJpoFHGVUEsS5yLPksnxEKjSa2mw/lib/libevent.a -lz -lbz2 -llzma /data/sandcastle/temp/fbcode_builder_getdeps/installed/lz4-EcyPuwYsuHakUlA-kWxer8wHvXjm9kQFsGAS-N5bd98/lib/liblz4.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/zstd-nu72lnvEO9fXOOi7ZDqer47syM_R4CVWONQAAxQ0V5g/lib/libzstd.so /data/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-w4Hybv-wJ190T-fglHVpnK3xq1CxUGT9RtVGDA7QpaM/lib/libsnappy.so -ldwarf -Wl,-Bstatic -liberty -Wl,-Bdynamic -lsodium -lunwind /data/sandcastle/temp/fbcode_builder_getdeps/installed/double-conversion-y46-Q4-Wds7DK27aDIxuW79GtOdq8ODZK6B7jzYHlhc/lib/libdouble-conversion.a /data/sandcastle/temp/fbcode_builder_getdeps/installed/gflags-xgCB_7eImt1ED3 (7a2fec883e641ecfe9c69aea83f3847ef7464698)QZZ0odZuKnfiDHhQTSb1BAKFNIuSE/lib/libgflags.so.2.2.2 /data/sandcastle/temp/fbcode_builder_getdeps/installed/glog-jbbNcEe1kvSNQWMMAJS0uF4p5E6ekVbf0Gcrgys6dDY/lib/libglog.so -lssl -lcrypto -ldl /data/sandcastle/temp/fbcode_builder_getdeps/installed/libsodium-e0bvqBDnJ4y9whbWaG6aIRWX0Xb17alEHHIoSi2Hz9c/lib/libsodium.so -lrt /data/sandcastle/temp/fbcode_builder_getdeps/installed/boost-YTxtJVn66eoEksgVRyTxbaq8DPPKh10XEOf_xFT94CY/lib/libboost_context.a -ldl /data/sandcastle/temp/fbcode_builder_getdeps/installed/googletest-C1jJnbUgB2bWMOXX9xwhVXibFypWvMRmxh6FuXDd4Hc/lib/libgtest.a -lpthread && :
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::RocketUpgradeAsyncClient::upgradeToRocketImpl(apache::thrift::RpcOptions const&, std::shared_ptr<apache::thrift::detail::ac::ClientRequestContext>, std::unique_ptr<apache::thrift::RequestClientCallback, apache::thrift::RequestClientCallback::RequestClientCallbackDeleter>)':
/data/sandcastle/temp/fbcode_builder_getdeps/build/fbthrift/thrift/lib/thrift/gen-cpp2/RocketUpgradeAsyncClient.cpp:61: undefined reference to `apache::thrift::detail::ac::throw_app_exn(char const*)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::preprocessSendT<apache::thrift::BinaryProtocolWriter>(apache::thrift::BinaryProtocolWriter*, apache::thrift::RpcOptions const&, apache::thrift::ContextStack&, apache::thrift::transport::THeader&, folly::Range<char const*>, folly::FunctionRef<void (apache::thrift::BinaryProtocolWriter*)>, folly::FunctionRef<unsigned long (apache::thrift::BinaryProtocolWriter*)>)::{lambda()#1}::operator()() const':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/async/RequestChannel.h:332: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `apache::thrift::preprocessSendT<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*, apache::thrift::RpcOptions const&, apache::thrift::ContextStack&, apache::thrift::transport::THeader&, folly::Range<char const*>, folly::FunctionRef<void (apache::thrift::CompactProtocolWriter*)>, folly::FunctionRef<unsigned long (apache::thrift::CompactProtocolWriter*)>)::{lambda()#1}::operator()() const':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/async/RequestChannel.h:332: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `folly::exception_wrapper apache::thrift::detail::ac::recv_wrapped_helper<apache::thrift::BinaryProtocolReader, apache::thrift::ThriftPresult<true> >(char const*, apache::thrift::BinaryProtocolReader*, apache::thrift::ClientReceiveState&, apache::thrift::ThriftPresult<true>&)':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.h:503: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'
/data/sandcastle/temp/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(RocketUpgradeAsyncClient.cpp.o): In function `folly::exception_wrapper apache::thrift::detail::ac::recv_wrapped_helper<apache::thrift::CompactProtocolReader, apache::thrift::ThriftPresult<true> >(char const*, apache::thrift::CompactProtocolReader*, apache::thrift::ClientReceiveState&, apache::thrift::ThriftPresult<true>&)':
/data/sandcastle/temp/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.h:503: undefined reference to `apache::thrift::checksum::crc32c(folly::IOBuf const&, unsigned long)'

FAILED: fbzmq/socket_test
: && /usr/bin/c++  -Wall -Wextra -Werror -Wno-noexcept-type -Wno-deprecated-declarations -O2 -g -DNDEBUG  -rdynamic fbzmq/CMakeFiles/socket_test.dir/zmq/tests/SocketTest.cpp.o  -o fbzmq/socket_test  -Wl,-rpath,/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/glog-Rqbf3AQfnM1pIMTNO0VZH5L2gvst-R0_2ena0nqk1mo/lib64:/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/gflags-vO_pvTYzLN9SWkXURwa6cRaxp70Hj86KE0DyrQM5IKk/lib:/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/libzmq-_8z7dmP07W_b-LvrcUAIkivGF6Uu1xCgAJ_kqB09Jck/lib:/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/zstd-ZJsxbZf68uCJ7Vz1We8SO6pkwbt1oc55C0-EhUBgxOs/lib64:/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/snappy-5hvYh82hARhvyeUX8hbN6NrNzgBgOhd7IyCR-eBmhWQ/lib64:/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/libsodium--JQk_Aex__Vn27x5ju_-noWQypZ6PNxS8ye8XzY1tMc/lib fbzmq/libfbzmq.a fbzmq/libtest_cpp2.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/folly/lib/libfolly.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/googletest-roLvBDEwbDYQx1Gp6obpa7FslX4eYR3oJNYwtIq5opM/lib64/libgtest.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/googletest-roLvBDEwbDYQx1Gp6obpa7FslX4eYR3oJNYwtIq5opM/lib64/libgtest_main.a fbzmq/libmonitor_cpp2.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/glog-Rqbf3AQfnM1pIMTNO0VZH5L2gvst-R0_2ena0nqk1mo/lib64/libglog.so /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/gflags-vO_pvTYzLN9SWkXURwa6cRaxp70Hj86KE0DyrQM5IKk/lib/libgflags.so.2.2.2 /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/libzmq-_8z7dmP07W_b-LvrcUAIkivGF6Uu1xCgAJ_kqB09Jck/lib/libzmq.so -lpthread -ldl /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftcpp2.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftfrozen2.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftmetadata.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthriftprotocol.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libasync.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libtransport.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/librpcmetadata.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libconcurrency.a -lz /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/libthrift-core.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/wangle/lib/libwangle.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fizz/lib/libfizz.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/folly/lib/libfolly.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_context.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fmt-HAn4S6KilDCf4tWqBldG1j0n4wnCVYKILXKX1uBTOek/lib64/libfmt.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_filesystem.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_program_options.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_regex.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_system.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_thread.a -pthread /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_chrono.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_date_time.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/boost-3qPc7TOCRy4bo035RXQyi7qfOlGBF1hg4_yymXkTYqU/lib/libboost_atomic.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/libevent-hsAi2sbhcjnmjkK_viQYSSVmrIpifomzL3-qSeLiZ_o/lib/libevent.a -lz /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/lz4-m5T8aYA0A-XwRjMYcbbpLy3VCcAybYwkBiI1PA_8fI8/lib64/liblz4.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/zstd-ZJsxbZf68uCJ7Vz1We8SO6pkwbt1oc55C0-EhUBgxOs/lib64/libzstd.so /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/snappy-5hvYh82hARhvyeUX8hbN6NrNzgBgOhd7IyCR-eBmhWQ/lib64/libsnappy.so -laio /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/double-conversion-HJC2WBX_7KWaN3X3W1Zheqtf239Y0g7aeVN1MaYQm6Y/lib/libdouble-conversion.a /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/gflags-vO_pvTYzLN9SWkXURwa6cRaxp70Hj86KE0DyrQM5IKk/lib/libgflags.so.2.2.2 /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/glog-Rqbf3AQfnM1pIMTNO0VZH5L2gvst-R0_2ena0nqk1mo/lib64/libglog.so -lssl -lcrypto -ldl /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/libsodium--JQk_Aex__Vn27x5ju_-noWQypZ6PNxS8ye8XzY1tMc/lib/libsodium.so -lrt /data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/googletest-roLvBDEwbDYQx1Gp6obpa7FslX4eYR3oJNYwtIq5opM/lib64/libgtest.a -lpthread && :
/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/installed/fbthrift/lib/librocketupgrade.a(GeneratedCodeHelper.cpp.o): In function `void apache::thrift::RequestsRegistry::Deleter::operator()<apache::thrift::ResponseChannelRequest>(apache::thrift::ResponseChannelRequest*)':
/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/server/RequestsRegistry.h:177: undefined reference to `apache::thrift::RequestsRegistry::moveToFinishedList(apache::thrift::RequestsRegistry::DebugStub&)'
/data/users/yixianj/scratch/dataZusersZyixianjZfbsource/fbcode_builder_getdeps/shipit/fbthrift/thrift/lib/cpp2/server/RequestsRegistry.h:181: undefined reference to `apache::thrift::RequestsRegistry::DebugStub::decRef()'
```

Reviewed By: jmswen

Differential Revision: D26318703

fbshipit-source-id: 5ac5b5a3ffec5c7a1293edcc7d44cbd9b1e1e09b

thrift/lib/cpp2/CMakeLists.txt

@@ -91,6 +91,9 @@ bypass_source_check("${RocketUpgrade-cpp2-SOURCES}")
 add_library(
   rocketupgrade
 
+  GeneratedCodeHelper.cpp
+  server/RequestsRegistry.cpp
+  util/Checksum.cpp
   ${RocketUpgrade-cpp2-SOURCES}
 )
 add_dependencies(rocketupgrade RocketUpgrade-cpp2-target)
@@ -235,7 +238,7 @@ install(
 
 if (BUILD_SHARED_LIBS)
   set_target_properties(rpcmetadata thriftmetadata thriftfrozen2 thriftprotocol
-    thriftcpp2
+    rocketupgrade thriftcpp2
     PROPERTIES VERSION ${PROJECT_VERSION}
     )
 endif()