-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eslint-plugin-import #3423
Use eslint-plugin-import #3423
Conversation
packages/jest-jasmine2/package.json
Outdated
@@ -17,5 +17,8 @@ | |||
"jest-snapshot": "^19.0.2", | |||
"once": "^1.4.0", | |||
"p-map": "^1.1.1" | |||
}, | |||
"devDependencies": { | |||
"jest-runtime": "^19.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added because of a type import. Should all types only exist in types/
?
Codecov Report
@@ Coverage Diff @@
## master #3423 +/- ##
==========================================
+ Coverage 62.25% 62.28% +0.03%
==========================================
Files 181 181
Lines 6716 6714 -2
Branches 6 6
==========================================
+ Hits 4181 4182 +1
+ Misses 2532 2529 -3
Partials 3 3
Continue to review full report at Codecov.
|
Pushed a commit disabling |
Seems like this one conflicts with pretty much everything, so we'll need to redo this PR :( |
I can redo it 😄 Seems like max-len stuff was done in #3444 |
Woohoo, thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Mentioned here: #2859 (comment)
Test plan
yarn lint