Move jest-runtime CLI into jest-repl #10016
Conversation
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
457b17f
to
e29c313
Compare
ghostd
changed the title
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
e29c313
to
9612f45
Compare
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
3 times, most recently
from
bc12a3f
to
1f3f457
Compare
Codecov Report
@@ Coverage Diff @@
## master #10016 +/- ##
==========================================
- Coverage 64.00% 63.99% -0.01%
==========================================
Files 297 296 -1
Lines 12528 12527 -1
Branches 3093 3093
==========================================
- Hits 8018 8017 -1
Misses 3860 3860
Partials 650 650
Continue to review full report at Codecov.
|
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
1c181ec
to
1cc8b7a
Compare
ghostd
changed the title
packages/jest-repl/package.json
Outdated
| "@jest/transform": "^26.0.1", | ||
| "@jest/types": "^26.0.1", | ||
| "@types/yargs": "^15.0.0", |
There was a problem hiding this comment.
@types/yargs is already present in devDependencies, it should be one or the other.
There was a problem hiding this comment.
Good catch, fixed (and rebased)
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
1cc8b7a
to
e758c8b
Compare
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
e758c8b
to
9687eed
Compare
|
@ghostd would you be able to rebase this? If not I can do it 🙂 |
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
9687eed
to
3b9ae7e
Compare
ghostd
force-pushed
the
move-runtime-cli-into-repl
branch
from
3b9ae7e
to
f5c0d8f
Compare
|
@SimenB i rebased the branch. Some tests seem fail (depends on the execution environment?) All tests pass on my box :-/ |
|
seems somewhat flakey - I'll investigate tonight or tomorrow. Thanks for rebasing! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #10011
Summary
Move jest-runtime CLI into jest-repl to break some circular dependencies
For now, i just moved the code into jest-repl. I think we should wait for complains before deeply merge the CLI code into the REPL code. If no one requires us to extract the CLI into its own package, we can merge it for Jest 28/29.
Test plan
The CLI tests has been moved with the code.