feat: report Individual Test Cases #10227

sauravhiremath · 2020-07-02T15:26:49Z

Summary ⚡

[Part 2 of 2] - Depends on [Part 1] Individual Test Case Report - Support custom messages #10293
Initially jest runs would update testSuites incrementally, and update individual test cases batch-wise. This PR attempts to report the progress of the individual (atomic) test-cases.
Supported for Jest-Circus Runner.
Introduces eventListeners for the worker processes to send back the test results to their parent.
Handles progress reports both when running tests parallelly (spawning workers) and inBand (Sequentially).

Previous References and suggestions

Fixes: Report progress of individual test cases #6616
Reference: [WIP][Proposal] Report progress of individual test cases #9001

Test plan ⚡

Add custom message support in jest-worker
Update onCustomMessage functions to pass tests (caused by updating its Type)
API implemented as suggested here - Report progress of individual test cases #6616 (comment)
Fix the memory leak issue

Current Implementation

Authors

Co-author - Saurav M. H @sauravhiremath
Co-author - Kunal Kushwaha @kunal-kushwaha
Co-author - Rogelio Guzman @rogeliog

Acknowledgements

@kunal-kushwaha for his super awesome contribution 🚀 🚀
@rogeliog for laying down the foundation for this PR. 🚀
@SimenB and @jevakallio for their time and reviews 👏

packages/jest-runner/src/runTest.ts

packages/jest-runner/src/index.ts

SimenB

Thanks, I think this is good to go! I'll hold off on merging until tomorrow to give more people the chance to review if they want.

Great job @kunal-kushwaha & @sauravhiremath! 👏

SimenB

no blockers by any means, I just went over the whole PR holistically one last time 🙂

packages/jest-core/src/TestScheduler.ts

packages/jest-reporters/src/utils.ts

SimenB · 2020-07-29T11:30:44Z

packages/jest-runner/src/__tests__/testRunner.test.ts

@@ -41,9 +41,9 @@ test('injects the serializable module map into each worker in watch mode', async
      {context, path: './file2.test.js'},
    ],
    new TestWatcher({isWatchMode: globalConfig.watch}),
-    () => {},


it would be nice with some new tests that verify the correct events are emitted

packages/jest-types/src/TestResult.ts

packages/jest-worker/src/workers/ChildProcessWorker.ts

packages/jest-core/src/TestScheduler.ts

SimenB · 2020-07-30T08:44:24Z

Can do #10227 (comment) when adding the test events discussed in #10227 (comment)

retorquere · 2020-07-30T08:51:05Z

In which release is this going to show up? And what do I have to change in my tests to make use of this?

SimenB · 2020-07-30T10:38:53Z

It's released in 26.2.0, and you don't have to change anything beyond using jest-circus

retorquere · 2020-08-02T16:29:35Z

I don't know what I'm doing wrong, but I'm still seeing all tests output at once when the last one finishes, and nothing before. I've create an MWE at https://github.com/retorquere/jest-circus-test. Would appreciate feedback on what I should be doing differently.

SimenB · 2020-12-23T17:47:22Z

packages/jest-runner/src/index.ts

@@ -90,18 +98,55 @@ class TestRunner {
              if (watcher.isInterrupted()) {
                throw new CancelRun();
              }
+              let sendMessageToJest: JestTestFileEvent;
+
+              // Remove `if(onStart)` in Jest 27


@sauravhiremath @kunal-kushwaha you wouldn't by any chance be up for sending a PR removing onStart etc? 🙂

@SimenB I'll be happy to look into it 😄

github-actions · 2021-05-10T23:06:31Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

rogeliog and others added 28 commits October 1, 2019 21:32

Add custom message support to jest-worker

71da2fc

WIP

4283f01

Add @SimenB's code

f34cfc7

It kind of works

6670252

WIP

d13455f

Better types

4bb9b1f

Update types

4d475c1

Add support for runInBand

c0cd04f

Remove jest-worker dependency from jest-circus

a6bb2ec

WIP

6331ae2

Fix tests and prevent breaking api

df62713

Fix lint issues

a7741c3

Add copyright header to new files

a045229

Merge branch 'master' into per-test-report

8042d4e

merged feature/custom-messages

0a135c6

wip: jest circus issue remains

295f7fe

fix: circus testResults concat only when type DescribeBlock

0937cf3

fix: removed test logs and comments

6aee98d

Merge branch 'master' into per-test-report

b34fb54

requested changes made

15279db

fix: changes + type updated

679d59e

Merge remote 'per-test-report' into per-test-report

f66dac9

fix: sourcesRelatedToTestsInChangedFiles added as paramter

4be1894

Merge branch 'master'

86ffc36

update: removed testCase not needed anymore

92e407e

chore: added @deprecated message

f7e4d8e

ParseTestResults not needed anymore

57bc280

feat: memory-leak fixed

f57b2a7

facebook-github-bot added the cla signed label Jul 2, 2020

kunal-kushwaha mentioned this pull request Jul 2, 2020

[Part 2] Individual Test Case Report - Report progress of individual test cases MLH-Fellowship/jest#6

Closed

10 tasks

update: add @SimenB's changes

6ffa6ae

SimenB reviewed Jul 28, 2020

View reviewed changes

packages/jest-runner/src/runTest.ts Outdated Show resolved Hide resolved

packages/jest-runner/src/index.ts Outdated Show resolved Hide resolved

SimenB reviewed Jul 28, 2020

View reviewed changes

packages/jest-runner/src/index.ts Outdated Show resolved Hide resolved

removed the UNSTABLE_prefix & resolved usages

d08c35d

kunal-kushwaha force-pushed the per-test-report branch from 9296d86 to d08c35d Compare July 28, 2020 10:43

fix: update test progress output

1f3d3f5

SimenB approved these changes Jul 28, 2020

View reviewed changes

packages/jest-runner/src/index.ts Show resolved Hide resolved

update: avoid breaking change + tests updated

5cc0b97

SimenB approved these changes Jul 28, 2020

View reviewed changes

SimenB requested a review from cpojer July 28, 2020 12:36

SimenB reviewed Jul 29, 2020

View reviewed changes

fix: added invariant for context and diffs removed

9c7013e

SimenB reviewed Jul 29, 2020

View reviewed changes

packages/jest-core/src/TestScheduler.ts Outdated Show resolved Hide resolved

sauravhiremath added 2 commits July 30, 2020 08:16

minor fix

7b7797c

Merge branch 'master' and changelog update

090296d

This was referenced Jul 30, 2020

Expose Total-test files via add-test event to jest-reporter MLH-Fellowship/jest#31

Closed

Expose Total-test files via add-test event to jest-reporter MLH-Fellowship/jest#32

Closed

DEBUG : [5] --> [6] MLH-Fellowship/jest#28

Closed

SimenB changed the title ~~[Part 2] Individual Test Case Report - Report Individual Test Cases~~ feat: report Individual Test Cases Jul 30, 2020

SimenB merged commit eb23ac1 into jestjs:master Jul 30, 2020

sauravhiremath mentioned this pull request Jul 30, 2020

[Internal] Jest runner limitations / adoption blockers microsoft/playwright#2971

Closed

8 tasks

SimenB deleted the per-test-report branch December 23, 2020 17:46

SimenB reviewed Dec 23, 2020

View reviewed changes

sauravhiremath mentioned this pull request Dec 25, 2020

[wip] Fix(jest-core): remove onAction awaits #10979

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: report Individual Test Cases #10227

feat: report Individual Test Cases #10227

sauravhiremath commented Jul 2, 2020 •

edited

Loading

SimenB left a comment •

edited

Loading

SimenB left a comment

SimenB Jul 29, 2020

SimenB commented Jul 30, 2020

retorquere commented Jul 30, 2020

SimenB commented Jul 30, 2020 •

edited

Loading

retorquere commented Aug 2, 2020

SimenB Dec 23, 2020

sauravhiremath Dec 24, 2020

github-actions bot commented May 10, 2021

feat: report Individual Test Cases #10227

feat: report Individual Test Cases #10227

Conversation

sauravhiremath commented Jul 2, 2020 • edited Loading

Summary ⚡

Previous References and suggestions

Test plan ⚡

Current Implementation

Authors

Acknowledgements

SimenB left a comment • edited Loading

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

SimenB Jul 29, 2020

Choose a reason for hiding this comment

SimenB commented Jul 30, 2020

retorquere commented Jul 30, 2020

SimenB commented Jul 30, 2020 • edited Loading

retorquere commented Aug 2, 2020

SimenB Dec 23, 2020

Choose a reason for hiding this comment

sauravhiremath Dec 24, 2020

Choose a reason for hiding this comment

github-actions bot commented May 10, 2021

sauravhiremath commented Jul 2, 2020 •

edited

Loading

SimenB left a comment •

edited

Loading

SimenB commented Jul 30, 2020 •

edited

Loading