feat: add support for <C-u> to clear line in prompt #11358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthsharma2
force-pushed
the
add-ctrl-u
branch
from
746b926
to
93a2b52
Compare
jeysal
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Nice, thanks!
@SimenB regarding your concern around "where does it end" as I commented in the issue I think we can happily accept further contributions for the things listed there, don't think it needs to come all at once though, this is a good start. Idk if you have other things to raise?- requested review
SimenB
approved these changes
Apr 30, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for clearing the line when
<C-u>is pressed in a watch mode pattern prompt. Resolves #11296Test plan
Added a test case that tests this change. Wasn't able to test it manually because of the
jest-watch-typeaheadplugin that uses the published version ofjest-watcherRefer: #11296 (comment)