Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maxDepth option in React plugins #4208

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

For example, just as the minified Expected/Received summary in jest-matcher-utils limits depth of JavaScript arrays or objects, so also for React elements or test objects.

Y’all are welcome to suggest alternative to <type … /> as the notation.

Test plan

Added 2 fail-first tests. Please forgive how verbose for my Pooh Bear brain to keep count.

@codecov-io
Copy link

Codecov Report

Merging #4208 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4208      +/-   ##
==========================================
+ Coverage   60.18%   60.19%   +0.01%     
==========================================
  Files         191      191              
  Lines        6763     6766       +3     
  Branches        6        6              
==========================================
+ Hits         4070     4073       +3     
  Misses       2690     2690              
  Partials        3        3
Impacted Files Coverage Δ
.../pretty-format/src/plugins/react_test_component.js 100% <100%> (ø) ⬆️
packages/pretty-format/src/plugins/lib/markup.js 100% <100%> (ø) ⬆️
...ackages/pretty-format/src/plugins/react_element.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6422d...f1dff5a. Read the comment docs.

@cpojer cpojer merged commit 3601d3a into jestjs:master Aug 7, 2017
@pedrottimark pedrottimark deleted the max-depth-markup branch August 7, 2017 19:36
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants