-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't run beforeAll/afterAll in skipped block #9931
Conversation
Nice and clean, thanks! This is missing a file to actually run the e2e test you've added. Something like https://github.com/facebook/jest/blob/7a7710d2c9cdc7da97a3674c36f1ca46f7068f78/e2e/__tests__/importedGlobals.test.ts |
Codecov Report
@@ Coverage Diff @@
## master #9931 +/- ##
=======================================
Coverage 64.23% 64.23%
=======================================
Files 292 292
Lines 12466 12466
Branches 3075 3076 +1
=======================================
Hits 8007 8007
Misses 3810 3810
Partials 649 649
Continue to review full report at Codecov.
|
Looks good, thanks @jeiea! Just missing a test file so the new e2e test actually runs. |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #6755
Fixes #8379
Test plan
e2e/__tests__/skipBeforeAfterAll.test.ts
corresponds to #8379 example. I checked it failed on previous revision.