Fix TypeError in case no files were found #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case no files are found then jscodeshift crashes with a
TypeError
aspendingWorkers
areundefined
, soPromise.all(pendingWorkers)
will fail.Output before this PR:
After this PR the output looks as expected:
Alternatives
I was considering if we should simply do a
process.exit
, but that wouldn't work if people use jscodeshift directly as a node dependency. I think the proposed solution here is the simplest for now.