bugfix: Avoid crash when there are no matching files #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the case of no files, the first promise of the runner returns undefined, however this leads to a `Cannot read property 'Symbol(Symbol.iterator)' of undefined` when you pass that undefined value into `Promise.all(pendingWorkers)`. The simple fix here is to return an empty array instead here so that `Promise.all([])` doesn't crash. Node version: v8.9.1
|
#295 already provided that fix, I just didn't get around to merging it. Thanks though! |
|
Ahh! Missed that PR. Thanks for merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the case of no files, the first promise of the runner returns undefined, however this leads to a
Cannot read property 'Symbol(Symbol.iterator)' of undefinedwhen you pass that undefined value intoPromise.all(pendingWorkers).The simple fix here is to return an empty array instead here so that
Promise.all([])doesn't crash.Node version: v8.9.1
Before:
After:
