From 54fe2f625e85f22934ee5a75e8955c4877088702 Mon Sep 17 00:00:00 2001 From: Fernando Cervera <86963649+fernandocervera-abi@users.noreply.github.com> Date: Thu, 17 Mar 2022 09:41:29 +0100 Subject: [PATCH 1/3] distinguish windows from mac keytool instructions --- docs/signed-apk-android.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/signed-apk-android.md b/docs/signed-apk-android.md index 0f9fbbdf074..2934f533511 100644 --- a/docs/signed-apk-android.md +++ b/docs/signed-apk-android.md @@ -7,7 +7,10 @@ Android requires that all apps be digitally signed with a certificate before the ## Generating an upload key -You can generate a private signing key using `keytool`. On Windows `keytool` must be run from `C:\Program Files\Java\jdkx.x.x_x\bin`. +You can generate a private signing key using `keytool`. + +### Windows +On Windows `keytool` must be run from `C:\Program Files\Java\jdkx.x.x_x\bin`. keytool -genkeypair -v -storetype PKCS12 -keystore my-upload-key.keystore -alias my-key-alias -keyalg RSA -keysize 2048 -validity 10000 @@ -15,6 +18,7 @@ This command prompts you for passwords for the keystore and key and for the Dist The keystore contains a single key, valid for 10000 days. The alias is a name that you will use later when signing your app, so remember to take note of the alias. +### Mac On Mac, if you're not sure where your JDK bin folder is, then perform the following command to find it: /usr/libexec/java_home From 077c70ec3e4acac91194e95d33bbb17aeefee237 Mon Sep 17 00:00:00 2001 From: Fernando Cervera <86963649+fernandocervera-abi@users.noreply.github.com> Date: Thu, 17 Mar 2022 09:45:46 +0100 Subject: [PATCH 2/3] prettier --- docs/signed-apk-android.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/signed-apk-android.md b/docs/signed-apk-android.md index 2934f533511..7f3283d22cf 100644 --- a/docs/signed-apk-android.md +++ b/docs/signed-apk-android.md @@ -10,6 +10,7 @@ Android requires that all apps be digitally signed with a certificate before the You can generate a private signing key using `keytool`. ### Windows + On Windows `keytool` must be run from `C:\Program Files\Java\jdkx.x.x_x\bin`. keytool -genkeypair -v -storetype PKCS12 -keystore my-upload-key.keystore -alias my-key-alias -keyalg RSA -keysize 2048 -validity 10000 @@ -19,6 +20,7 @@ This command prompts you for passwords for the keystore and key and for the Dist The keystore contains a single key, valid for 10000 days. The alias is a name that you will use later when signing your app, so remember to take note of the alias. ### Mac + On Mac, if you're not sure where your JDK bin folder is, then perform the following command to find it: /usr/libexec/java_home From 00b18415f5adbd342837548ec39778c47a133d9b Mon Sep 17 00:00:00 2001 From: Fernando Cervera <86963649+fernandocervera-abi@users.noreply.github.com> Date: Fri, 18 Mar 2022 07:01:04 +0100 Subject: [PATCH 3/3] Update docs/signed-apk-android.md Co-authored-by: Bartosz Kaszubowski --- docs/signed-apk-android.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/signed-apk-android.md b/docs/signed-apk-android.md index 7f3283d22cf..4c422d03e9c 100644 --- a/docs/signed-apk-android.md +++ b/docs/signed-apk-android.md @@ -19,9 +19,9 @@ This command prompts you for passwords for the keystore and key and for the Dist The keystore contains a single key, valid for 10000 days. The alias is a name that you will use later when signing your app, so remember to take note of the alias. -### Mac +### macOS -On Mac, if you're not sure where your JDK bin folder is, then perform the following command to find it: +On macOS, if you're not sure where your JDK bin folder is, then perform the following command to find it: /usr/libexec/java_home