From 1062e0fb6f4efeee883af0c239079127ee6db6ab Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Wed, 9 Nov 2022 09:08:43 +0000 Subject: [PATCH] Fix: ensure that Codegen podspec don't force dependencies --- .../cocoapods/__tests__/codegen_utils-test.rb | 24 ++++++++--------- scripts/cocoapods/codegen_utils.rb | 26 +++++++++---------- 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/scripts/cocoapods/__tests__/codegen_utils-test.rb b/scripts/cocoapods/__tests__/codegen_utils-test.rb index 989b7e87857788..35f732efac60ce 100644 --- a/scripts/cocoapods/__tests__/codegen_utils-test.rb +++ b/scripts/cocoapods/__tests__/codegen_utils-test.rb @@ -458,16 +458,16 @@ def get_podspec_no_fabric_no_script ].join(' ') }, 'dependencies': { - "FBReactNativeSpec": ["99.98.97"], - "React-jsiexecutor": ["99.98.97"], - "RCT-Folly": ["2021.07.22.00"], - "RCTRequired": ["99.98.97"], - "RCTTypeSafety": ["99.98.97"], - "React-Core": ["99.98.97"], - "React-jsi": ["99.98.97"], - "hermes-engine": ["99.98.97"], - "ReactCommon/turbomodule/bridging": ["99.98.97"], - "ReactCommon/turbomodule/core": ["99.98.97"] + "FBReactNativeSpec": [], + "React-jsiexecutor": [], + "RCT-Folly": [], + "RCTRequired": [], + "RCTTypeSafety": [], + "React-Core": [], + "React-jsi": [], + "hermes-engine": [], + "ReactCommon/turbomodule/bridging": [], + "ReactCommon/turbomodule/core": [] } } end @@ -476,8 +476,8 @@ def get_podspec_fabric_and_script_phases(script_phases) specs = get_podspec_no_fabric_no_script() specs[:dependencies].merge!({ - 'React-graphics': ["99.98.97"], - 'React-rncore': ["99.98.97"], + 'React-graphics': [], + 'React-rncore': [], }) specs[:'script_phases'] = script_phases diff --git a/scripts/cocoapods/codegen_utils.rb b/scripts/cocoapods/codegen_utils.rb index bd1c4648049eb9..488098d6b6561d 100644 --- a/scripts/cocoapods/codegen_utils.rb +++ b/scripts/cocoapods/codegen_utils.rb @@ -98,32 +98,32 @@ def get_react_codegen_spec(package_json_file, folly_version: '2021.07.22.00', fa ].join(' ') }, 'dependencies': { - "FBReactNativeSpec": [version], - "React-jsiexecutor": [version], - "RCT-Folly": [folly_version], - "RCTRequired": [version], - "RCTTypeSafety": [version], - "React-Core": [version], - "React-jsi": [version], - "ReactCommon/turbomodule/bridging": [version], - "ReactCommon/turbomodule/core": [version] + "FBReactNativeSpec": [], + "React-jsiexecutor": [], + "RCT-Folly": [], + "RCTRequired": [], + "RCTTypeSafety": [], + "React-Core": [], + "React-jsi": [], + "ReactCommon/turbomodule/bridging": [], + "ReactCommon/turbomodule/core": [] } } if fabric_enabled spec[:'dependencies'].merge!({ - 'React-graphics': [version], - 'React-rncore': [version], + 'React-graphics': [], + 'React-rncore': [], }); end if hermes_enabled spec[:'dependencies'].merge!({ - 'hermes-engine': [version], + 'hermes-engine': [], }); else spec[:'dependencies'].merge!({ - 'React-jsc': [version], + 'React-jsc': [], }); end