From 2013c2cd67b15ea6957c7fa75acc8ae181173020 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 9 Aug 2023 11:56:44 -0700 Subject: [PATCH] Fix Android build warning Summary: Fix Android build warning reporting usage of depreacted APIs: Robolectric.setupActivity() is deprecated in Android unit test Following Google Android recommendations: https://developer.android.com/reference/androidx/test/core/app/ActivityScenario changelog: [internal] internal Reviewed By: cortinico Differential Revision: D48168983 fbshipit-source-id: ac37235715578af6e28da2e219c6a942bfafca2a --- .../com/facebook/react/modules/share/ShareModuleTest.kt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/share/ShareModuleTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/share/ShareModuleTest.kt index 2327b6cc07d0fe..eb21c9b43c0d6f 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/share/ShareModuleTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/share/ShareModuleTest.kt @@ -7,8 +7,8 @@ package com.facebook.react.modules.share -import android.app.Activity import android.content.Intent +import androidx.fragment.app.FragmentActivity import com.facebook.react.bridge.JavaOnlyMap import com.facebook.react.bridge.Promise import com.facebook.react.bridge.ReactTestHelper @@ -23,19 +23,20 @@ import org.robolectric.Robolectric import org.robolectric.RobolectricTestRunner import org.robolectric.RuntimeEnvironment import org.robolectric.Shadows.shadowOf +import org.robolectric.android.controller.ActivityController import org.robolectric.annotation.Config @Config(shadows = [ShadowArguments::class]) @RunWith(RobolectricTestRunner::class) class ShareModuleTest { - private lateinit var activity: Activity private lateinit var shareModule: ShareModule + private lateinit var activityController: ActivityController @Before fun prepareModules() { - activity = Robolectric.setupActivity(Activity::class.java) - + activityController = Robolectric.buildActivity(FragmentActivity::class.java) + val activity = activityController.create().start().resume().get() val applicationContext = ReactTestHelper.createCatalystContextForTest() applicationContext.onNewIntent(activity, Intent()) shareModule = ShareModule(applicationContext)