From 31f219977ddf87c19b4c65dd74058fd3f081ef0a Mon Sep 17 00:00:00 2001 From: Arthur Kushka Date: Mon, 17 Oct 2022 16:17:17 -0700 Subject: [PATCH] Disabled cpp view managers in runtime Summary: We found this feature crashing the app during hot reload, and as there is no user code dependent on it so far, we decided to disable it until we find the root cause. changelog: [internal] internal Reviewed By: mdvacca Differential Revision: D40445312 fbshipit-source-id: fe28b58c5dca6c91389ad38675ca37669a4965a0 --- ReactAndroid/src/main/jni/react/fabric/Binding.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/jni/react/fabric/Binding.cpp b/ReactAndroid/src/main/jni/react/fabric/Binding.cpp index 5b93fe83ce015b..4afe8bd8475349 100644 --- a/ReactAndroid/src/main/jni/react/fabric/Binding.cpp +++ b/ReactAndroid/src/main/jni/react/fabric/Binding.cpp @@ -377,9 +377,11 @@ void Binding::installFabricUIManager( << this << ")."; } - sharedCppComponentRegistry_ = - std::shared_ptr( - cppComponentRegistry ? cppComponentRegistry : nullptr); + // TODO[T135327389]: Investigate why code relying on CppComponentRegistry + // crashing during hot reload restart. + // sharedCppComponentRegistry_ = + // std::shared_ptr( + // cppComponentRegistry ? cppComponentRegistry : nullptr); // Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes // at the same time