From 6b6adcc111123bec2c4c110070b2506385e74664 Mon Sep 17 00:00:00 2001 From: Kudo Chien Date: Fri, 6 May 2022 11:38:00 -0700 Subject: [PATCH] add back hermes inspector support (#33778) Summary: the `WITH_INSPECTOR` build flag is missing from cmake migration. original we had it in [Application.mk](https://github.com/facebook/react-native/blob/ed46ea2058b909a2dd401347d68956324961ec2c/ReactAndroid/src/main/jni/Application.mk#L29) this pr adds back the build flag and make hermes inspector (or debugging hermes in flipper) work again. ## Changelog [Android] [Fixed] - add back hermes inspector support Pull Request resolved: https://github.com/facebook/react-native/pull/33778 Test Plan: test on rn-tester hermes variant Reviewed By: cipolleschi Differential Revision: D36204525 Pulled By: cortinico fbshipit-source-id: 417874a7d0e05b5ee886f3160d526ff9c2df44ee --- ReactAndroid/src/main/jni/react/jni/CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt b/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt index e1a8f58857a598..e001b79550d3b8 100644 --- a/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt +++ b/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt @@ -14,7 +14,8 @@ add_compile_options( -fexceptions -frtti -Wno-unused-lambda-capture - -std=c++17) + -std=c++17 + -DWITH_INSPECTOR=1) ########################## ### React Native Utils ###