From 6be46b0bb59f2d88bc78e9a72db672bd55914fa7 Mon Sep 17 00:00:00 2001 From: Paige Sun Date: Fri, 7 Jan 2022 17:40:39 -0800 Subject: [PATCH] Comments only. Clarify a few Venice and SVC methods Summary: Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D33468276 fbshipit-source-id: bcc62ba1e728bba2492dbbbb0e4569285effeca7 --- Libraries/NativeComponent/NativeComponentRegistry.js | 1 + React/Fabric/Mounting/RCTComponentViewFactory.mm | 1 + 2 files changed, 2 insertions(+) diff --git a/Libraries/NativeComponent/NativeComponentRegistry.js b/Libraries/NativeComponent/NativeComponentRegistry.js index 89722e7ca34276..92db800de558b1 100644 --- a/Libraries/NativeComponent/NativeComponentRegistry.js +++ b/Libraries/NativeComponent/NativeComponentRegistry.js @@ -116,6 +116,7 @@ export function getWithFallback_DEPRECATED( viewConfigProvider: () => PartialViewConfig, ): React.AbstractComponent { if (getRuntimeConfig == null) { + // `getRuntimeConfig == null` when static view configs are disabled // If `setRuntimeConfigProvider` is not configured, use native reflection. if (hasNativeViewConfig(name)) { return get(name, viewConfigProvider); diff --git a/React/Fabric/Mounting/RCTComponentViewFactory.mm b/React/Fabric/Mounting/RCTComponentViewFactory.mm index 27361df9376583..cf5a9181243b78 100644 --- a/React/Fabric/Mounting/RCTComponentViewFactory.mm +++ b/React/Fabric/Mounting/RCTComponentViewFactory.mm @@ -41,6 +41,7 @@ using namespace facebook::react; +// Allow JS runtime to register native components as needed. For static view configs. void RCTInstallNativeComponentRegistryBinding(facebook::jsi::Runtime &runtime) { auto hasComponentProvider = [](std::string const &name) -> bool {