From 713b6b930f16a9f5b6ed84cf7cf71ad38fb0922a Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 22 Jul 2024 16:17:15 +0100 Subject: [PATCH] [LOCAL][RN][CI] Fix Hermes for iOS in CI --- .circleci/configurations/jobs.yml | 3 +++ package.json | 3 ++- .../sdks/hermes-engine/utils/build-ios-framework.sh | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.circleci/configurations/jobs.yml b/.circleci/configurations/jobs.yml index f1662164d2e512..19eff332c9075d 100644 --- a/.circleci/configurations/jobs.yml +++ b/.circleci/configurations/jobs.yml @@ -786,6 +786,9 @@ jobs: - HERMES_WS_DIR: *hermes_workspace_root - HERMES_TARBALL_ARTIFACTS_DIR: *hermes_tarball_artifacts_dir - HERMES_OSXBIN_ARTIFACTS_DIR: *hermes_osxbin_artifacts_dir + - XROS_DEPLOYMENT_TARGET: "1.0" + - MACOSX_DEPLOYMENT_TARGET: "10.15" + - IPHONEOS_DEPLOYMENT_TARGET: "13.4" steps: - *attach_hermes_workspace - stop_job_if_apple_artifacts_are_there: diff --git a/package.json b/package.json index cf49d6835f629e..b5907dc055fa23 100644 --- a/package.json +++ b/package.json @@ -112,5 +112,6 @@ "supports-color": "^7.1.0", "typescript": "5.0.4", "ws": "^6.2.2" - } + }, + "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" } diff --git a/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh index 77045508d74dd5..225cb55b02c79e 100755 --- a/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh +++ b/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh @@ -26,9 +26,9 @@ function get_architecture { function get_deployment_target { if [[ $1 == "xros" || $1 == "xrsimulator" ]]; then - "$(get_visionos_deployment_target)" + echo "$(get_visionos_deployment_target)" else - "$(get_ios_deployment_target)" + echo "$(get_ios_deployment_target)" fi }