From 88c43490a1937acda3abe51bb29eac88dffe399e Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 1 Feb 2021 10:56:31 -0800 Subject: [PATCH] Fix initial placeholder in multiline TextInput Summary: Changelog: [internal] `[self _invalidatePlaceholderVisibility]` wasn't triggered in multiline text input in Fabric. Even in Paper it was triggered what to me seems like coincidence rather than intention (I might be wrong). This is more explicit, visibility of placeholder text needs to be re-evaluated every time placeholder text is changed. Reviewed By: shergin Differential Revision: D26172754 fbshipit-source-id: 3a767d333b79c266a3d70a96883b1289fff16750 --- Libraries/Text/TextInput/Multiline/RCTUITextView.m | 1 + 1 file changed, 1 insertion(+) diff --git a/Libraries/Text/TextInput/Multiline/RCTUITextView.m b/Libraries/Text/TextInput/Multiline/RCTUITextView.m index a417cc11751099..2d6f6eb43a31c8 100644 --- a/Libraries/Text/TextInput/Multiline/RCTUITextView.m +++ b/Libraries/Text/TextInput/Multiline/RCTUITextView.m @@ -282,6 +282,7 @@ - (void)_invalidatePlaceholderVisibility - (void)_updatePlaceholder { _placeholderView.attributedText = [[NSAttributedString alloc] initWithString:_placeholder ?: @"" attributes:[self _placeholderTextAttributes]]; + [self _invalidatePlaceholderVisibility]; } - (NSDictionary *)_placeholderTextAttributes