Fabric: Setting up correct pointScaleFactor in Binding::startSurface

shergin · facebook-github-bot · commit 99ece27897f7 · 2019-06-18T19:35:35.000-07:00
Summary: Previously, we didn't provide any LayoutContext to the very first commit (aka startSurface); apparently it causes problems.

Reviewed By: mdvacca

Differential Revision: D15891472

fbshipit-source-id: b2a785bdad5764eb97b41f5bf5679807107bd8a0
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
@@ -73,8 +73,10 @@ void Binding::startSurface(
     return;
   }
 
+  LayoutContext context;
+  context.pointScaleFactor = pointScaleFactor_;
   scheduler->startSurface(
-      surfaceId, moduleName->toStdString(), initialProps->consume());
+      surfaceId, moduleName->toStdString(), initialProps->consume(), {}, context);
 }
 
 void Binding::startSurfaceWithConstraints(

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,10 @@ void Binding::startSurface(`
`73`	`73`	`return;`
`74`	`74`	`}`
`75`	`75`
	`76`	`+ LayoutContext context;`
	`77`	`+ context.pointScaleFactor = pointScaleFactor_;`
`76`	`78`	`scheduler->startSurface(`
`77`		`- surfaceId, moduleName->toStdString(), initialProps->consume());`
	`79`	`+ surfaceId, moduleName->toStdString(), initialProps->consume(), {}, context);`
`78`	`80`	`}`
`79`	`81`
`80`	`82`	`void Binding::startSurfaceWithConstraints(`