From a5c57b4ed4965ac4bb231399fd145da8095cece3 Mon Sep 17 00:00:00 2001 From: Piotr Trocki Date: Tue, 7 May 2019 04:03:51 -0700 Subject: [PATCH] onKeyPress is not fired on Android when entering an Emoji (#24717) Summary: Resolve #24690 This is very simple unicode detecting. Should I improve this solution creating StringsUtils for detecting unicodes in whole react-native project ? [Android][Fixed] onKeyPress method is calling, when user type emoji Pull Request resolved: https://github.com/facebook/react-native/pull/24717 Differential Revision: D15238388 Pulled By: cpojer fbshipit-source-id: 038b1040e1c44fd6f9401a3988a782f5778e1209 --- .../views/textinput/ReactEditTextInputConnectionWrapper.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java index 23e9888315a55d..f9aa450b19e3e7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java @@ -108,8 +108,8 @@ public boolean setComposingText(CharSequence text, int newCursorPosition) { @Override public boolean commitText(CharSequence text, int newCursorPosition) { String key = text.toString(); - // Assume not a keyPress if length > 1 - if (key.length() <= 1) { + // Assume not a keyPress if length > 1 (or 2 if unicode) + if (key.length() <= 2) { if (key.equals("")) { key = BACKSPACE_KEY_VALUE; }