Skip to content

Commit

Permalink
Fix race condition when reporting mounting transactions for deallocat…
Browse files Browse the repository at this point in the history
…ed surfaces (#47008)

Summary:
Pull Request resolved: #47008

Changelog: [internal]

This code is gated anyway so there's no harm in production.

Reviewed By: javache

Differential Revision: D64322331

fbshipit-source-id: 005eb385f7e5ccd3d33e2d8c28e45b84f1537d68
  • Loading branch information
rubennorte authored and facebook-github-bot committed Oct 14, 2024
1 parent 60bc3c5 commit b527177
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ void FabricUIManagerBinding::reportMount(SurfaceId surfaceId) {
}
}
if (surfaceHandler != nullptr) {
surfaceHandler->getMountingCoordinator()->didPerformAsyncTransactions();
auto mountingCoordinator = surfaceHandler->getMountingCoordinator();
if (mountingCoordinator != nullptr) {
mountingCoordinator->didPerformAsyncTransactions();
}
}
} else {
LOG(ERROR) << "FabricUIManagerBinding::reportMount: Surface with id "
Expand Down

0 comments on commit b527177

Please sign in to comment.