From c01d9fe8d943ce9fbcfa57d87647d1b2d4dbdf57 Mon Sep 17 00:00:00 2001 From: Kevin Cooper Date: Tue, 18 Apr 2017 11:59:16 -0400 Subject: [PATCH] Output warning when stack trace is undefined --- React/Base/RCTJSCErrorHandling.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/React/Base/RCTJSCErrorHandling.mm b/React/Base/RCTJSCErrorHandling.mm index 21dd74b85f77a0..3030c19b613e2d 100644 --- a/React/Base/RCTJSCErrorHandling.mm +++ b/React/Base/RCTJSCErrorHandling.mm @@ -13,6 +13,7 @@ #import "RCTAssert.h" #import "RCTJSStackFrame.h" +#import "RCTLog.h" NSString *const RCTJSExceptionUnsymbolicatedStackTraceKey = @"RCTJSExceptionUnsymbolicatedStackTraceKey"; @@ -25,7 +26,9 @@ userInfo[NSLocalizedFailureReasonErrorKey] = exceptionMessage; } NSString *const stack = [exception[@"stack"] toString]; - if ([stack length]) { + if ([@"undefined" isEqualToString:stack]) { + RCTLogWarn(@"Couldn't get stack trace for %@:%@", exception[@"sourceURL"], exception[@"line"]); + } else if ([stack length]) { NSArray *const unsymbolicatedFrames = [RCTJSStackFrame stackFramesWithLines:stack]; userInfo[RCTJSStackTraceKey] = unsymbolicatedFrames; }