Skip to content

Commit daaa1b2

Browse files
Peter Arganyfacebook-github-bot
authored andcommitted
Remove code supporting legacy paper interop from Picker view manager
Summary: Picker was migrated to Fabric in stack ending in D23663596 (8f45db3). Therefore, Picker's paper view manager is never used in Fabric through LegacyInteropLayer. This diff deletes a codepath that was created to accommodate this interop layer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D27245596 fbshipit-source-id: e574e4aedcfef0ae639cb2aa446e27d6db5e9b94
1 parent 05418f8 commit daaa1b2

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

React/Views/RCTPickerManager.m

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,10 @@ - (UIView *)view
4848
{
4949
[self.bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
5050
UIView *view = viewRegistry[viewTag];
51-
5251
if ([view isKindOfClass:[RCTPicker class]]) {
5352
[(RCTPicker *)view setSelectedIndex:index.integerValue];
5453
} else {
55-
// This component is used in Fabric through LegacyInteropLayer.
56-
// `RCTPicker` view is subview of `RCTLegacyViewManagerInteropComponentView`.
57-
// `viewTag` passed as parameter to this method is tag of the `RCTLegacyViewManagerInteropComponentView`.
58-
UIView *subview = [uiManager viewForReactTag:viewTag].subviews.firstObject;
59-
if ([subview isKindOfClass:[RCTPicker class]]) {
60-
[(RCTPicker *)subview setSelectedIndex:index.integerValue];
61-
} else {
62-
RCTLogError(@"view type must be RCTPicker");
63-
}
54+
RCTLogError(@"View type must be RCTPicker!");
6455
}
6556
}];
6657
}

0 commit comments

Comments
 (0)