-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate NativeModuleRegistryBuilder to Kotlin (#47508)
Summary: Pull Request resolved: #47508 Changelog: [Internal] Reviewed By: tdn120 Differential Revision: D60037204 fbshipit-source-id: 2b405e492520e075b83a075009d25fb7b7fa8925
- Loading branch information
1 parent
2ec547a
commit e3c3a0c
Showing
4 changed files
with
66 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
...act-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.java
This file was deleted.
Oops, something went wrong.
61 changes: 61 additions & 0 deletions
61
...react-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
package com.facebook.react | ||
|
||
import com.facebook.react.bridge.ModuleHolder | ||
import com.facebook.react.bridge.NativeModuleRegistry | ||
import com.facebook.react.bridge.ReactApplicationContext | ||
|
||
/** Helper class to build NativeModuleRegistry. */ | ||
public class NativeModuleRegistryBuilder( | ||
private val reactApplicationContext: ReactApplicationContext, | ||
) { | ||
|
||
private val modules = HashMap<String, ModuleHolder>() | ||
|
||
@Deprecated( | ||
"ReactInstanceManager is not used", | ||
ReplaceWith("NativeModuleRegistryBuilder(reactApplicationContext)")) | ||
public constructor( | ||
reactApplicationContext: ReactApplicationContext, | ||
@Suppress("UNUSED_PARAMETER") reactInstanceManager: ReactInstanceManager | ||
) : this(reactApplicationContext) {} | ||
|
||
public fun processPackage(reactPackage: ReactPackage) { | ||
// We use an iterable instead of an iterator here to ensure thread safety, and that this list | ||
// cannot be modified | ||
val moduleHolders = | ||
@Suppress("DEPRECATION") | ||
if (reactPackage is LazyReactPackage) { | ||
reactPackage.getNativeModuleIterator(reactApplicationContext) | ||
} else if (reactPackage is BaseReactPackage) { | ||
reactPackage.getNativeModuleIterator(reactApplicationContext) | ||
} else { | ||
ReactPackageHelper.getNativeModuleIterator(reactPackage, reactApplicationContext) | ||
} | ||
for (moduleHolder in moduleHolders) { | ||
val name = moduleHolder.name | ||
val existingNativeModule = modules[name] | ||
if (existingNativeModule != null) { | ||
check(moduleHolder.canOverrideExistingModule) { | ||
""" | ||
Native module $name tried to override ${existingNativeModule.className}. | ||
Check the getPackages() method in MainApplication.java, it might be that module is being created twice. | ||
If this was your intention, set canOverrideExistingModule=true. This error may also be present if the | ||
package is present only once in getPackages() but is also automatically added later during build time | ||
by autolinking. Try removing the existing entry and rebuild. | ||
""" | ||
} | ||
} | ||
modules[name] = moduleHolder | ||
} | ||
} | ||
|
||
public fun build(): NativeModuleRegistry = NativeModuleRegistry(reactApplicationContext, modules) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters