Skip to content

Commit

Permalink
Fix Basic SVC for RNTester iOS (#46439)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #46439

The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.

With this change, I updated the manually written SVC so that we don't have warnings anymore.

We still have to fix the `boxShadow` and `filter`. This will happen in a later change.

## Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester

Reviewed By: NickGerleman

Differential Revision: D62501704

fbshipit-source-id: 3c02f7615c3511a97eba73a2ddaa713d2e4e30f0
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Sep 13, 2024
1 parent f3fee67 commit fad4a07
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ export const __INTERNAL_VIEW_CONFIG: PartialViewConfig =
snapToInterval: true,
snapToOffsets: true,
snapToStart: true,
verticalScrollIndicatorInsets: {
diff: require('../../Utilities/differ/insetsDiffer'),
},
zoomScale: true,
...ConditionallyIgnoredEventHandlers({
onScrollBeginDrag: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,15 @@ const RCTTextInputViewConfig = {
topContentSizeChange: {
registrationName: 'onContentSizeChange',
},
topChangeSync: {
registrationName: 'onChangeSync',
},
topKeyPressSync: {
registrationName: 'onKeyPressSync',
},
},
validAttributes: {
dynamicTypeRamp: true,
fontSize: true,
fontWeight: true,
fontVariant: true,
Expand Down Expand Up @@ -151,6 +158,8 @@ const RCTTextInputViewConfig = {
onSelectionChange: true,
onContentSizeChange: true,
onScroll: true,
onChangeSync: true,
onKeyPressSync: true,
}),
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ const validAttributesForNonEventProps = {
testID: true,
backgroundColor: {process: require('../StyleSheet/processColor').default},
backfaceVisibility: true,
cursor: true,
opacity: true,
shadowColor: {process: require('../StyleSheet/processColor').default},
shadowOffset: {diff: require('../Utilities/differ/sizesDiffer')},
Expand All @@ -216,8 +217,10 @@ const validAttributesForNonEventProps = {
role: true,
borderRadius: true,
borderColor: {process: require('../StyleSheet/processColor').default},
borderBlockColor: {process: require('../StyleSheet/processColor').default},
borderCurve: true,
borderWidth: true,
borderBlockWidth: true,
borderStyle: true,
hitSlop: {diff: require('../Utilities/differ/insetsDiffer')},
collapsable: true,
Expand All @@ -240,9 +243,15 @@ const validAttributesForNonEventProps = {
borderLeftWidth: true,
borderLeftColor: {process: require('../StyleSheet/processColor').default},
borderStartWidth: true,
borderBlockStartWidth: true,
borderStartColor: {process: require('../StyleSheet/processColor').default},
borderBlockStartColor: {
process: require('../StyleSheet/processColor').default,
},
borderEndWidth: true,
borderBlockEndWidth: true,
borderEndColor: {process: require('../StyleSheet/processColor').default},
borderBlockEndColor: {process: require('../StyleSheet/processColor').default},

borderTopLeftRadius: true,
borderTopRightRadius: true,
Expand Down

0 comments on commit fad4a07

Please sign in to comment.