Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onPressIn/Out and onLongPress props to TouchableHighlight/Opacity #101

Closed
ide opened this issue Feb 26, 2015 · 1 comment
Closed

Add onPressIn/Out and onLongPress props to TouchableHighlight/Opacity #101

ide opened this issue Feb 26, 2015 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Feb 26, 2015

This would let TouchableHighlight/Opacity be supersets of TouchableWithoutFeedback while still retaining the highlight / fade behavior. Does this make sense? I will send a PR if so.
@sahrens
Copy link
Contributor

sahrens commented Feb 26, 2015

Yeah, just didn't get around to it :)

On Feb 25, 2015, at 5:26 PM, James Ide notifications@github.com wrote:

This would let TouchableHighlight/Opacity be supersets of TouchableWithoutFeedback while still retaining the highlight / fade behavior. Does this make sense? I will send a PR if so.

—
Reply to this email directly or view it on GitHub.

@ide ide mentioned this issue Feb 26, 2015
Closed
@ide ide closed this as completed Mar 2, 2015
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 13, 2015
@ide
[Touch] Suite of touchable events on TouchableHighlight/Opacity
d5b0d84 
Summary:
The following props are now supported on TouchableHighlight/Opacity components:

 - onPress (was there before)
 - onPressIn
 - onPressOut
 - onLongPress

There is a `TouchableFeedbackPropType` that is shared amongst the Touchable family for consistency.

Added UIExplorer example to demonstrate and test.

Fixes facebook#101.
Closes facebook#102
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 14, 2015
@ide
[Touch] Suite of touchable events on TouchableHighlight/Opacity
a7f2fd2 
Summary:
The following props are now supported on TouchableHighlight/Opacity components:

 - onPress (was there before)
 - onPressIn
 - onPressOut
 - onLongPress

There is a `TouchableFeedbackPropType` that is shared amongst the Touchable family for consistency.

Added UIExplorer example to demonstrate and test.

Fixes facebook#101.
Closes facebook#102
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 15, 2015
@ide
[Touch] Suite of touchable events on TouchableHighlight/Opacity
3373294 
Summary:
The following props are now supported on TouchableHighlight/Opacity components:

 - onPress (was there before)
 - onPressIn
 - onPressOut
 - onLongPress

There is a `TouchableFeedbackPropType` that is shared amongst the Touchable family for consistency.

Added UIExplorer example to demonstrate and test.

Fixes facebook#101.
Closes facebook#102
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Touch] Suite of touchable events on TouchableHighlight/Opacity
3 participants
@ide @sahrens @react-native-bot