-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TouchableBounce] Split up into separate module #1550
Comments
Doesn't matter who's the owner of the repo? |
One step closer to join Facebook organisation 🎱 Ok, will dig into that. |
Haha awesome thanks 💯 |
@grabbou any progress on splitting this into a separate module? |
Yeah, I've started last Saturday as I finally had enough time to understand how these sub-project all work, so will publish it probably tomorrow along with few other modules I was working on. Thank you for this reminder ;) |
👍 awesome thanks @grabbou! |
@brentvatne what should I do with the copyright headers in files? Shall I keep them + include your licence? |
@grabbou - I'd make it as similar as you can to what FB has in React Native :) |
Ok, will keep all the things and send you a link to private repo so we can work out the legal issues before it goes live :) |
In progress. To be published by 5 pm I guess. |
Status of issue? |
This has been fixed and you can now consume TouchableBounce from npm: https://github.com/grabbou/react-native-touchable-bounce There's open PR for doing the same in main react-native repo, however it's loosely coupled with this issue itself. |
As per #1545, this library should be pulled out into a separate project that is installable via npm.
The text was updated successfully, but these errors were encountered: