Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TouchableBounce] Split up into separate module #1550

Closed
brentvatne opened this issue Jun 7, 2015 · 13 comments
Closed

[TouchableBounce] Split up into separate module #1550

brentvatne opened this issue Jun 7, 2015 · 13 comments
Assignees
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@brentvatne
Copy link
Collaborator

As per #1545, this library should be pulled out into a separate project that is installable via npm.

@brentvatne brentvatne added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 7, 2015
@grabbou
Copy link
Contributor

grabbou commented Jun 8, 2015

Doesn't matter who's the owner of the repo?

@brentvatne
Copy link
Collaborator Author

@grabbou - if you create one and @vjeux would prefer it to be on the Facebook account we can look at transferring it 😄

@grabbou
Copy link
Contributor

grabbou commented Jun 15, 2015

One step closer to join Facebook organisation 🎱 Ok, will dig into that.

@brentvatne
Copy link
Collaborator Author

Haha awesome thanks 💯

@browniefed
Copy link
Contributor

@grabbou any progress on splitting this into a separate module?

@grabbou
Copy link
Contributor

grabbou commented Jul 20, 2015

Yeah, I've started last Saturday as I finally had enough time to understand how these sub-project all work, so will publish it probably tomorrow along with few other modules I was working on. Thank you for this reminder ;)

@brentvatne
Copy link
Collaborator Author

👍 awesome thanks @grabbou!

@grabbou
Copy link
Contributor

grabbou commented Jul 21, 2015

@brentvatne what should I do with the copyright headers in files? Shall I keep them + include your licence?

@brentvatne
Copy link
Collaborator Author

@grabbou - I'd make it as similar as you can to what FB has in React Native :)

@grabbou
Copy link
Contributor

grabbou commented Jul 22, 2015

Ok, will keep all the things and send you a link to private repo so we can work out the legal issues before it goes live :)

@grabbou
Copy link
Contributor

grabbou commented Oct 1, 2015

In progress. To be published by 5 pm I guess.

@joshuagutierrez
Copy link

Status of issue?

@grabbou grabbou self-assigned this Mar 7, 2016
@grabbou
Copy link
Contributor

grabbou commented Mar 20, 2016

This has been fixed and you can now consume TouchableBounce from npm: https://github.com/grabbou/react-native-touchable-bounce

There's open PR for doing the same in main react-native repo, however it's loosely coupled with this issue itself.

@grabbou grabbou closed this as completed Mar 20, 2016
@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants