[Packager] Add "dev" option to CLI #112
Conversation
Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate.
|
I thought we already omit source maps in the production build. Maybe we have an internal script to do that, if that's not the case and we do ship source maps, then that's pretty clowny. Anyways, thanks, will pull it shortly. |
|
Thanks @amasad. From what I could tell, the code that generates the source string always concatenated the source map so your production build script (maybe it is a person?) might just truncate the end of the file. I noticed the source map (and file size -- minification helps too) really affect performance on the phone. This is just a rough idea but longer-term it would improve on-device development to have the packager always minify and have the phone be able to load source maps separately. Or if minification compromises debuggability, then it could make sense to expose a option in the package URL to toggle minification so that the simulator can load a non-minified bundle. |
You're right, I just checked the script strips out the source map.
Yes, we talked about this. We want to have As for minification, with sourcemaps it should be the same debugging experience. That could be an option in the URL. It's worth noting that it could be slow to minify the bundle on each request, especially if we want to preserve sourcemaps. I wonder how much minification really affect performance, unless we're talking about Closure Compiler -- which does inlining and dead code elimination -- I'm doubtful that there is much change on runtime perf. |
|
I don't have perf numbers but anecdotally the minified JS is faster for a bunch of little reasons that add up. For boot time it helps to read fewer bytes off of disk / from the packager server, and to run the code the app has to copy the string from Obj-C to JS. |
|
closed via caf21ae |
Summary: Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate. Closes facebook#112 Github Author: James Ide <ide@jameside.com> Test Plan: * ./runJestTests.sh * test bundle creation with `bundle.sh` * test `load_dependencies.js` script * start the server and click around shell app
Summary: Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate. Closes facebook#112 Github Author: James Ide <ide@jameside.com> Test Plan: * ./runJestTests.sh * test bundle creation with `bundle.sh` * test `load_dependencies.js` script * start the server and click around shell app
Summary: Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate. Closes facebook#112 Github Author: James Ide <ide@jameside.com> Test Plan: * ./runJestTests.sh * test bundle creation with `bundle.sh` * test `load_dependencies.js` script * start the server and click around shell app
Summary: Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate. Closes facebook/react-native#112 Github Author: James Ide <ide@jameside.com> Test Plan: * ./runJestTests.sh * test bundle creation with `bundle.sh` * test `load_dependencies.js` script * start the server and click around shell app
…i-fix-pct-margin-padding Support % for margin
Closes facebook#16 When the statusbar is not translucent, the view resizes when the keyboard is shown on Android. The tab bar stays above the keyboard. This PR makes the tab bar hide automatically when the keyboard is shown. The behaviour is enabled by default and can be disabled with `keyboardHidesTabBar: false` in `tabBarOptions`
Exposes the dev option that is already there to the CLI so that you can turn off invariant checks, etc. I also made it omit the inlined source map when dev=false which made it a lot faster to run on a phone, both due to smaller download size and fewer bytes to copy from Obj-C to JS and evaluate.