From e29e998f57986423f102292854c280de52b9b1b5 Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Tue, 15 Aug 2017 16:22:28 -0400 Subject: [PATCH] Use offset adjusted value in ModulusAnimatedNode Modulus animation computation should use the value adjusted for offset, not the raw value. See the JS implementation here: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/AnimatedImplementation.js#L1338 --- .../java/com/facebook/react/animated/ModulusAnimatedNode.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java index 102ff12001e227..11fa7fc274c308 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java @@ -31,7 +31,7 @@ public ModulusAnimatedNode( public void update() { AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNode); if (animatedNode != null && animatedNode instanceof ValueAnimatedNode) { - mValue = ((ValueAnimatedNode) animatedNode).mValue % mModulus; + mValue = ((ValueAnimatedNode) animatedNode).getValue() % mModulus; } else { throw new JSApplicationCausedNativeException("Illegal node ID set as an input for " + "Animated.modulus node");